From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A99C433DB for ; Thu, 11 Mar 2021 11:00:03 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 783D664FCD for ; Thu, 11 Mar 2021 11:00:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 783D664FCD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 42C1E182D; Thu, 11 Mar 2021 11:59:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 42C1E182D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1615460399; bh=wuYQ5go7U89NxbgrgChLoksFkX9xu4wX7m8J5n2YGDc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oQKrGczePiah/nCktuYpT/8S7qYz5G9z5nJRa42hCd2/05hVdqYNM9WOGZ/wlW/EH HK/n80DfX+lCSSzCjXSOrVYhkT9bd3kjlaD+HCEBs5V8lS6pl+sXAEAvHuk7rsejsW HhP/6eB6RHYzEaN0nzihv7zSTWOyVDhcEUNV58WI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BA9BCF8015B; Thu, 11 Mar 2021 11:59:08 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2B357F80227; Thu, 11 Mar 2021 11:59:06 +0100 (CET) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1A900F8015B for ; Thu, 11 Mar 2021 11:58:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1A900F8015B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CNiSwaWS" Received: by mail-qk1-x732.google.com with SMTP id n79so20102955qke.3 for ; Thu, 11 Mar 2021 02:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3UiH+kUE+AB5h+QM3HtJZhWpgi2YQCcTnzrYrkv0thQ=; b=CNiSwaWS5Le1oZOW3/IlTMc86hDM8oGd/z9Mu8/Y7NzcHshvFyki/EPYDtukE9mMwk 2nJP4YLekvXzZOyjYiiwD7sRtWIoWiUQqJo9Ma5/6uLftQXQzn25Tv8DsR+7siFdjozF 44D84jlB0d9hF9F53+DHHOsVqBJskxr6ZGXCZqmCWHPbjPd876ymHd8CcjX3kldN3LAK d6bP5fvaHztHMR37LDG5MAZ/At4tz+QFJNOCWRR8oHlJ0pe3XlZE5wE5PjeZuFVAMA8S MoU1XZcAMi8YUKX5zMgkzsIGq5vmS3A/paXvynY0mobidIf+axslWfRimcaA/eQelLGy um7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3UiH+kUE+AB5h+QM3HtJZhWpgi2YQCcTnzrYrkv0thQ=; b=TyXHfEGR83cVFOfOY3LgF40ngOTN87IvOUUTurAcUXYnCPLE/Sr6CuysV9grlWhT1D o/0ZajrLbzRcpxAIdXXIixe5t7qdchYSO+hXn0e3A1weQSl+jOFCMyRFgiwtHlb9G11/ R5xtZsV2KEhoSGuH9bNXnpkqdUoMdYHto2GTG2wEt4jtMGv76Dd03dL16Lq4D9YDztTI DGTVNMQEnBKPlzih50URiyAABBEA0B94LTWS3jVqiA1zaoTb7mHQl0E5Ad/Jf6li/dqa rKlJGrY+/OkqBPYCB5caXskWL/y6AeiqAhWEIgIy5WxOj8QBP3ACRTdd2+67w8+336QS sYSA== X-Gm-Message-State: AOAM5322ZKqcwDIsQLoy5VKFVUubdIU8+MTv5d/32n0lZ5WYGDvWAJ2N XXG1GUyr3xCQ+F/DuKxt6WB35vwE1mA9oPvsDSI= X-Google-Smtp-Source: ABdhPJyZ4u6nofR+JIYN9svyff7NaaVy50y13tHZKajwjGXKpJ+Yq1BGxZ4ry9Z5DaYVyjV58HY7A1+TajTQE80FhTM= X-Received: by 2002:a05:620a:718:: with SMTP id 24mr6897580qkc.121.1615460333507; Thu, 11 Mar 2021 02:58:53 -0800 (PST) MIME-Version: 1.0 References: <1615209750-2357-1-git-send-email-shengjiu.wang@nxp.com> <1615209750-2357-4-git-send-email-shengjiu.wang@nxp.com> <20210310024834.GA1623179@robh.at.kernel.org> In-Reply-To: From: Shengjiu Wang Date: Thu, 11 Mar 2021 18:58:42 +0800 Message-ID: Subject: Re: [PATCH v4 3/6] ASoC: dt-bindings: fsl_rpmsg: Add binding doc for rpmsg cpu dai driver To: Rob Herring Content-Type: text/plain; charset="UTF-8" Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-ALSA , Timur Tabi , Xiubo Li , Fabio Estevam , Shengjiu Wang , Takashi Iwai , Liam Girdwood , linux-kernel , Nicolin Chen , Mark Brown , linuxppc-dev X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Rob On Thu, Mar 11, 2021 at 5:12 AM Rob Herring wrote: > > On Wed, Mar 10, 2021 at 6:33 AM Shengjiu Wang wrote: > > > > Hi Rob > > > > On Wed, Mar 10, 2021 at 10:49 AM Rob Herring wrote: > > > > > > On Mon, Mar 08, 2021 at 09:22:27PM +0800, Shengjiu Wang wrote: > > > > fsl_rpmsg cpu dai driver is driver for rpmsg audio, which is mainly used > > > > > > Bindings describe h/w blocks, not drivers. > > > > I will modify the descriptions. but here it is a virtual device. the > > mapping in real h/w is cortex M core, Cortex M core controls the SAI, > > DMA interface. What we see from Linux side is a audio service > > through rpmsg channel. > > It's describing the h/w from the view of the OS. It's not important > that it's a Cortex-M, but how you interface to it whether that's > shared registers, mailbox, etc. And it's what resources the block uses > that the OS controls. ok. > > > > > for getting the user's configuration from device tree and configure the > > > > clocks which is used by Cortex-M core. So in this document define the > > > > needed property. > > > > > > > > Signed-off-by: Shengjiu Wang > > > > --- > > > > .../devicetree/bindings/sound/fsl,rpmsg.yaml | 118 ++++++++++++++++++ > > > > 1 file changed, 118 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml b/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml > > > > new file mode 100644 > > > > index 000000000000..5731c1fbc0a6 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml > > > > @@ -0,0 +1,118 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/sound/fsl,rpmsg.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: NXP Audio RPMSG CPU DAI Controller > > > > + > > > > +maintainers: > > > > + - Shengjiu Wang > > > > + > > > > +description: | > > > > + fsl_rpmsg cpu dai driver is virtual driver for rpmsg audio, which doesn't > > > > + touch hardware. It is mainly used for getting the user's configuration > > > > + from device tree and configure the clocks which is used by Cortex-M core. > > > > + So in this document define the needed property. > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - fsl,imx7ulp-rpmsg > > > > + - fsl,imx8mn-rpmsg > > > > + - fsl,imx8mm-rpmsg > > > > + - fsl,imx8mp-rpmsg > > > > + > > > > + model: > > > > + $ref: /schemas/types.yaml#/definitions/string > > > > + description: User specified audio sound card name > > > > + > > > > + clocks: > > > > + items: > > > > + - description: Peripheral clock for register access > > > > + - description: Master clock > > > > + - description: DMA clock for DMA register access > > > > + - description: Parent clock for multiple of 8kHz sample rates > > > > + - description: Parent clock for multiple of 11kHz sample rates > > > > + minItems: 5 > > > > > > If this doesn't touch hardware, what are these clocks for? > > > > When the cortex-M core support audio service, these clock > > needed prepared & enabled by ALSA driver. > > > > > > > > You don't need 'minItems' unless it's less than the number of 'items'. > > > > Ok, I will remove this minItems. > > > > > > > > > + > > > > + clock-names: > > > > + items: > > > > + - const: ipg > > > > + - const: mclk > > > > + - const: dma > > > > + - const: pll8k > > > > + - const: pll11k > > > > + minItems: 5 > > > > + > > > > + power-domains: > > > > + maxItems: 1 > > > > + > > > > + fsl,audioindex: > > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > + enum: [0, 1] > > > > + default: 0 > > > > + description: Instance index for sound card in > > > > + M core side, which share one rpmsg > > > > + channel. > > > > > > We don't do indexes in DT. What's this numbering tied to? > > > > I will remove it. it is not necessary > > > > > > > > > + > > > > + fsl,version: > > > > > > version of what? > > > > > > This seems odd at best. > > > > > > > I will remove it. it is not necessary > > > > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > + enum: [1, 2] > > > > > > You're going to update this with every new firmware version? > > > > > > > + default: 2 > > > > + description: The version of M core image, which is > > > > + to make driver compatible with different image. > > > > + > > > > + fsl,buffer-size: > > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > + description: pre allocate dma buffer size > > > > > > How can you have DMA, this doesn't touch h/w? > > > > The DMA is handled by M core image for sound playback > > and capture. we need to allocated buffer in Linux side. > > here just make the buffer size to be configurable. > > Do we set audio buffer sizes for other audio devices in DT? If not, > why is this special? If so, why is it not common. No. I will move it to driver. > > > > > + fsl,enable-lpa: > > > > + $ref: /schemas/types.yaml#/definitions/flag > > > > + description: enable low power audio path. > > > > + > > > > + fsl,rpmsg-out: > > > > + $ref: /schemas/types.yaml#/definitions/flag > > > > + description: | > > > > + This is a boolean property. If present, the transmitting function > > > > + will be enabled. > > > > + > > > > + fsl,rpmsg-in: > > > > + $ref: /schemas/types.yaml#/definitions/flag > > > > + description: | > > > > + This is a boolean property. If present, the receiving function > > > > + will be enabled. > > > > + > > > > + fsl,codec-type: > > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > + enum: [0, 1, 2] > > > > + default: 0 > > > > + description: Sometimes the codec is registered by > > > > + driver not by the device tree, this items > > > > + can be used to distinguish codecs. > > > > > > How does one decide what value to use? > > > > I will add more description: > > 0: dummy codec > > 1: WM8960 codec > > 2: AK4497 codec > > I assume the last 2 cases have nodes in DT (pointed to by > 'audio-codec'), so this is redundant. Ok, will remove it. > > > > > + > > > > + audio-codec: > > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > > + description: The phandle of the audio codec > > > > > > The codec is controlled from the Linux side? > > > > yes. > > > > > > > > > + > > > > + memory-region: > > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > > + description: phandle to the reserved memory nodes > > > > + > > > > +required: > > > > + - compatible > > > > + - fsl,audioindex > > > > + - fsl,version > > > > + - fsl,buffer-size > > > > + > > > > +additionalProperties: false > > > > + > > > > +examples: > > > > + - | > > > > + rpmsg_audio: rpmsg_audio { > > > > + compatible = "fsl,imx8mn-rpmsg"; > > > > + fsl,audioindex = <0> ; > > > > + fsl,version = <2>; > > > > + fsl,buffer-size = <0x6000000>; > > > > + fsl,enable-lpa; > > > > > > How does this work? Don't you need somewhere to put the 'rpmsg' data? > > > > The rpmsg data is not handled in this "rpmsg_audio" device, it is just to > > prepare the resource for rpmsg audio function, the clock, the memory > > the power... > > > > The rpmsg data is handled in imx-pcm-rpmsg.c and imx-audio-rpmsg.c > > These devices is registered by imx remoteproc driver. > > Then what is 'memory-region' for? You need that, a mailbox, or ??? > somewhere in DT. > The M core can't access all the DDR memory space on some platform, so use 'memory-region' reserve a specific memory for dma buffer which M core can access. best regards wang shengjiu