Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Ikjoon Jang <ikjn@chromium.org>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: linux-kernel@vger.kernel, alsa-devel@alsa-project.org,
	Olivia Mackintosh <livvy@base.nu>,
	Dylan Robinson <dylan_robinson@motu.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
	Alexander Tsoy <alexander@tsoy.me>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Gregor Pintar <grpintar@gmail.com>,
	Dmitry Panchenko <dmitry@d-systems.ee>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect
Date: Wed, 24 Mar 2021 20:03:14 +0800
Message-ID: <CAATdQgDrri-tMtu3AOFRcbGHfL6hONDfdMdZh45BusbdAoWfdw@mail.gmail.com> (raw)
In-Reply-To: <c21de867cf4ccbfcc8cf555c78dc70dd3a47dfe8.camel@infinera.com>

On Wed, Mar 24, 2021, 7:16 PM Joakim Tjernlund <
Joakim.Tjernlund@infinera.com> wrote:

> On Wed, 2021-03-24 at 18:51 +0800, Ikjoon Jang wrote:
> > Logitech ConferenceCam Connect is a compound USB device with UVC and
> > UAC. Not 100% reproducible but sometimes it keeps responding STALL to
> > every control transfer once it receives get_freq request.
> >
> > This patch adds 046d:0x084c to a snd_usb_get_sample_rate_quirk list.
> >
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203419
> > Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>
> Most Logitech USB headset I got needs a delay in snd_usb_ctl_msg_quirk()
> Have you tried to add say 20 ms delay in there?
>
>
I didn't try that. But it sounds reasonable to me.

let me try that quirk here. If that is the case, HID might need that delay
also. Logitech Group webcam had a similar problem on control xfer of
get_report from an another interface for HID.

And 20ms can be too long if it's applied to every control transfer. I will
test the device with shorter delay if you didn't try it before.

Any additional advice is welcome.

Thanks!

 Jocke
>
>

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24 10:51 Ikjoon Jang
2021-03-24 11:16 ` Joakim Tjernlund
2021-03-24 12:03   ` Ikjoon Jang [this message]
2021-03-24 12:05     ` Dmitry Panchenko | d-Systems
2021-03-24 12:49     ` Takashi Iwai
2021-03-25 11:01       ` Joakim Tjernlund
2021-03-29  6:23       ` Ikjoon Jang
2021-03-29 11:23         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAATdQgDrri-tMtu3AOFRcbGHfL6hONDfdMdZh45BusbdAoWfdw@mail.gmail.com \
    --to=ikjn@chromium.org \
    --cc=Joakim.Tjernlund@infinera.com \
    --cc=alexander@tsoy.me \
    --cc=alsa-devel@alsa-project.org \
    --cc=dmitry@d-systems.ee \
    --cc=dylan_robinson@motu.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=grpintar@gmail.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=livvy@base.nu \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git