From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH 5/9] drm: bridge/dw_hdmi: avoid being recursive in N calculation Date: Fri, 4 Sep 2015 10:50:19 -0700 Message-ID: References: <20150808160936.GN7557@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Russell King Cc: "open list:ARM/Rockchip SoC..." , alsa-devel@alsa-project.org, "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Philipp Zabel , Andy Yan , Yakir Yang , Fabio Estevam , Mark Brown , Takashi Iwai , Jaroslav Kysela , Sascha Hauer , Jon Nettleton , David Airlie List-Id: alsa-devel@alsa-project.org Russell, On Sat, Aug 8, 2015 at 9:10 AM, Russell King wrote: > There's no need to be recursive when computing the N value for the ACR > packet - we can instead calculate the multiplier prior to our switch() > based lookup, and multiply the N value appropriately afterwards. > > Signed-off-by: Russell King > --- > drivers/gpu/drm/bridge/dw_hdmi.c | 25 +++++++++---------------- > 1 file changed, 9 insertions(+), 16 deletions(-) For what it's worth, I backported this change into my local 3.14-based tree and it worked for me. It also looks good to me. Reviewed-by: Douglas Anderson Tested-by: Douglas Anderson