From: Daniel Baluta <daniel.baluta@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
"Sridharan, Ranjani" <ranjani.sridharan@intel.com>
Subject: Re: [alsa-devel] Question about FE & BE DPCM
Date: Fri, 1 Nov 2019 23:41:33 +0200 [thread overview]
Message-ID: <CAEnQRZA9APzcCz-N=+WpgEA6w-EO54W=Wqc59FCWi2AP8u_3ng@mail.gmail.com> (raw)
In-Reply-To: <87o8yi6c7x.wl-kuninori.morimoto.gx@renesas.com>
On Tue, Oct 15, 2019 at 4:15 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
>
> Hi Daniel
>
> > » /* BE is dummy */
> > » » codecs->of_node»» = NULL;
> > » » codecs->dai_name» = "snd-soc-dummy-dai";
> > » » codecs->name» » = "snd-soc-dummy";
> >
> > » » /* FE settings */
> > » » dai_link->dynamic» » = 1;
> > » » dai_link->dpcm_merged_format» = 1;
>
> Ahh, indeed... it is wrong comment.
> It should be /* Codec is dummy */ here.
> I will post fixup patch, soon.
>
> Current simple-card is assuming
>
> FE: CPU-dummy
> BE: dummy-Codec
>
> > asoc_simple_canonicalize_platform function where it does say:
> >
> > » * DPCM BE can be no platform.
> > » * Alloced memory will be waste, but not leak.
> > » */
> > » if (!dai_link->platforms->of_node)
> > » » dai_link->num_platforms = 0;
> >
> > But I do want to create a BE with a platform. So, should I try to
> > revert the following
>
> I see.
> I'm not using but someone added asoc_simple_parse_platform().
> Maybe it can help you (?), but it is not called/used under DPCM case.
> If you can support it under DPCM, asoc_simple_canonicalize_platform()
> is no longer your issue ?
Yes, this would definitely help. Now I'm trying to figure out an acceptable
way to create just one link with:
FE: CPU-dummy
BE: dummy-Codec
Or even better just one:
BE: dummy-Codec.
Both audio-graph-card.c and simple-card.c deal with DPCM only with
this conditions:
» » » /*
» » » * It is DPCM
» » » * if Codec port has many endpoints,
» » » * or has convert-xxx property
» » » */
or
» » » if (dpcm_selectable &&
» » » (num > 2 ||
» » » adata.convert_rate || adata.convert_channels))
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-11-01 21:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 21:05 [alsa-devel] Question about FE & BE DPCM Daniel Baluta
2019-10-11 21:56 ` Sridharan, Ranjani
2019-10-12 9:20 ` Daniel Baluta
2019-10-15 1:15 ` Kuninori Morimoto
2019-11-01 21:41 ` Daniel Baluta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEnQRZA9APzcCz-N=+WpgEA6w-EO54W=Wqc59FCWi2AP8u_3ng@mail.gmail.com' \
--to=daniel.baluta@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=ranjani.sridharan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).