From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D450AC433E0 for ; Fri, 31 Jul 2020 08:58:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B28720838 for ; Fri, 31 Jul 2020 08:58:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="iU0DbvrF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aE1OHoox" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B28720838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C1BCB1687; Fri, 31 Jul 2020 10:58:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C1BCB1687 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596185936; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iU0DbvrFHqCdWOoqLofbLvGfmfXUX30ytUtRo6uFyCSfP4AVDUSZQhO0PeTDxNnZv zA5t8aVQRI4t/c8v4bd/OxMvdF3vHtbqqc26WVEIyynKHCHO1lIa2nCQmN5geyM6BM ugF+g7hDuh5MGnUB3Dh/hS+zUx/a93lJcqlx9fSg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2D769F802E1; Fri, 31 Jul 2020 10:56:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 97A08F802E2; Fri, 31 Jul 2020 10:56:22 +0200 (CEST) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7885DF802DF for ; Fri, 31 Jul 2020 10:56:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7885DF802DF Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aE1OHoox" Received: by mail-wr1-x442.google.com with SMTP id r12so27217125wrj.13 for ; Fri, 31 Jul 2020 01:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; b=aE1OHooxwN4CtoTfKoukXZmAijnt7lUt7g2YEmORS3cT7AcMzMNPBMqe8jdLYclZBm eOHaWEarxXuFCjto12aNCFolbMakz+DiEVyPF5mrDDnb4gRfoCRQPp7jBy5l2R7n/un1 nBoT11Vhvh4xhvgqwcqKCnGpBSQmKQyJHI6yE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; b=h44Z88Hx5N5Z/YdmP9onFnhGBrc7hTSvqLTDG1KKG/3EXWOEqu48gfgwsu2G4yiW0q Oz0nXNDbcwwIE1EK2KH5lrGuVjHTNRpCa7K+SzTsg6nIWEqJaqeVVNhwb/sctYN3wXkq ebJxUM261EN9sL+9j+E4HqfqHtHl82Qan+TDCJKmpCrZHiQkeDT70vIs3JWcsAz7kIqc Vp2OLJAGjZAah9nYS0vx1Tf6NWqmxGbihsOImJ2L9SH/QTI/4MtmSOibU6lSXhAHjjJB Q2yjgp6CpDA8NB2ev7poYG970YZe9Pqv28C+rR/GpNOIlrl0QuuY2NOsSarDOiwcP/Qz XFWQ== X-Gm-Message-State: AOAM530EedZ6gGC6h2erTTUz7oZVU94pq35cgPhAaO0lKeuXBEFpp9Cj KbWSv1VWIbJmdzBsBLcFnaB3u6277Y+x/f5IzhyGDQ== X-Google-Smtp-Source: ABdhPJzWn3jZhPtcamUMQKgiq4Q2WoIJL296BZio2qPps8qapt7QAgo3rn4E433qso7peWw9XBVW+myXjp0sLi36trw= X-Received: by 2002:adf:e486:: with SMTP id i6mr2505317wrm.258.1596185775852; Fri, 31 Jul 2020 01:56:15 -0700 (PDT) MIME-Version: 1.0 References: <20200721104422.369368-1-cychiang@chromium.org> <20200721104422.369368-3-cychiang@chromium.org> <20200723184432.GA321518@gerhold.net> In-Reply-To: <20200723184432.GA321518@gerhold.net> From: Cheng-yi Chiang Date: Fri, 31 Jul 2020 16:55:49 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration To: Stephan Gerhold Content-Type: text/plain; charset="UTF-8" Cc: Taniya Das , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tzung-Bi Shih , Banajit Goswami , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Liam Girdwood , linux-arm-msm , Patrick Lai , Takashi Iwai , linux-kernel , Rob Herring , Bjorn Andersson , Mark Brown , Rohit kumar , Andy Gross , Doug Anderson , Srinivas Kandagatla , Dylan Reid , Ajit Pandey , Linux ARM X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Jul 24, 2020 at 2:45 AM Stephan Gerhold wrote: > > On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote: > > > +static int sc7180_parse_of(struct snd_soc_card *card) > > > +{ > > > > This code is getting duplicated in various places like apq8016_sbc_parse_of, > > it will be nice to common this up, if possible! > > > > FYI, I started work on making apq8016_sbc use qcom_snd_parse_of() > a while ago already, but didn't find the time to finish it up. > I have now sent it, this should make it possible to use the common > qcom_snd_parse_of() function in this driver as well. > > See: https://lore.kernel.org/alsa-devel/20200723183904.321040-1-stephan@gerhold.net/ > > Stephan > Hi Stephan, thanks a lot for jumping on this to help. It indeed makes this new driver much cleaner. I have tested with your patches and it works great.