From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6278FC433EF for ; Sun, 8 Sep 2019 13:52:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E16D420854 for ; Sun, 8 Sep 2019 13:52:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="NYeig3FB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gVLsd+T0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E16D420854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 09AC29F6; Sun, 8 Sep 2019 15:51:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 09AC29F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1567950745; bh=sfT+brxQ8G70z844MrwOmS2NxSMYO4C44U2nnZfQ778=; h=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NYeig3FBb3DvwT1AXxw9wmo/7AGi5seQSteuyM8feci0YLOTlxqiz0ySIqMzQHHgv 8bKr4zOMuSG68u+1/4saSiptx656jHehXAUZoD0etqktMLHfvU1Ekm/YmeF387dM7I D5kYhE1LoCpDDuMwoX3MATXAWgwWefT7xYj4ScLs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 79CD6F802DF; Sun, 8 Sep 2019 15:51:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3386EF80368; Sun, 8 Sep 2019 15:51:33 +0200 (CEST) Received: from mail-ua1-x944.google.com (mail-ua1-x944.google.com [IPv6:2607:f8b0:4864:20::944]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 19000F800C1 for ; Sun, 8 Sep 2019 15:51:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 19000F800C1 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gVLsd+T0" Received: by mail-ua1-x944.google.com with SMTP id f9so3465004uaj.4 for ; Sun, 08 Sep 2019 06:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/OjUEd4QSp7PdF6VW4aQrBE3Z+/uVpO6ArZ5TFedKOc=; b=gVLsd+T0GXYo4KXD8R+kiCVmUyc3iXlvJ5SL3N90TjeV223lfZq0lpVImmm1TQPLvr biVG3B/n3OMziPN/L+IVvhgX7Ge1Bk7hcW/JG/CkZ9zrfy4+DonIP5+MTrsf/9lW9zj+ GDyNN76Ur/2fW2BBK/M7SqE9yXZfqSEsSHkh4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/OjUEd4QSp7PdF6VW4aQrBE3Z+/uVpO6ArZ5TFedKOc=; b=uj26nVXx7rbSNVpcNwPxYMeqeA2/AvDhP/bBqVE4twn3e21l2aQx4WwV0Fr031IDCy uTbVm4ugqm+1XY29Jr3gY5pq0QB0SkYjdscQTz/4OYF7n8UtYJwbLHJGocBq+F/HCk7Y JzCiOenhLji0ijY6oVbD2qI0o/vdkwIMRpRQd+/vjtacFiIbx2O2d6/DKpTXIXLChZck XuJJBKIER/GR3iR9VXXDfCYvEHzkmWXS+vgxn5tQUvnlHTRSjaxJCN4NivyqJRbxiTgP eUBU3OxQ74OcSv4dR2/uVFd15c0/yU7USgkQ6Y8kC6whsMGQspvDbhgaVsuJb2sfXrOU opRw== X-Gm-Message-State: APjAAAXzQs/0ZFZQSQbvSKZn1CU5bQ5KXjBBHOPy+0u9ThQizAun3Y60 b9KGZqeYcqUxygkEu/Y791Nk2WoHyk3RAmYZra6MyA== X-Google-Smtp-Source: APXvYqz0WcmHMeiK6IT+v7kmZTAGTgr1Hd/fvxS4YbL4elq2hJMpg584VDsJiFFWnsbRAAo6uqeDZQp5p3+XGhBLzrU= X-Received: by 2002:ab0:7c3:: with SMTP id d3mr8981573uaf.131.1567950687342; Sun, 08 Sep 2019 06:51:27 -0700 (PDT) MIME-Version: 1.0 References: <20190717083327.47646-1-cychiang@chromium.org> In-Reply-To: From: Cheng-yi Chiang Date: Sun, 8 Sep 2019 21:51:01 +0800 Message-ID: To: Tzung-Bi Shih Cc: ALSA development , Douglas Anderson , Heiko Stuebner , Liam Girdwood , David Airlie , dri-devel@lists.freedesktop.org, Neil Armstrong , Takashi Iwai , tzungbi@chromium.org, Linux Kernel Mailing List , Hans Verkuil , Andrzej Hajda , Russell King , Mark Brown , Laurent Pinchart , Daniel Vetter , linux-rockchip@lists.infradead.org, Dylan Reid , linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH v5 0/5] Add HDMI jack support on RK3288 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Aug 30, 2019 at 10:55 AM Cheng-yi Chiang wrote: > > On Wed, Jul 17, 2019 at 6:28 PM Tzung-Bi Shih wrote: > > > > On Wed, Jul 17, 2019 at 4:33 PM Cheng-Yi Chiang wrote: > > > > > > This patch series supports HDMI jack reporting on RK3288, which uses > > > DRM dw-hdmi driver and hdmi-codec codec driver. > > > > > > The previous discussion about reporting jack status using hdmi-notifier > > > and drm_audio_component is at > > > > > > https://lore.kernel.org/patchwork/patch/1083027/ > > > > > > The new approach is to use a callback mechanism that is > > > specific to hdmi-codec. > > > > > > Changes from v4 to v5: > > > - synopsys/Kconfig: Remove the incorrect dependency change in v4. > > > - rockchip/Kconfig: Add dependency of hdmi-codec when it is really need > > > for jack support. > > > > > > Cheng-Yi Chiang (5): > > > ASoC: hdmi-codec: Add an op to set callback function for plug event > > > drm: bridge: dw-hdmi: Report connector status using callback > > > drm: dw-hdmi-i2s: Use fixed id for codec device > > > ASoC: rockchip_max98090: Add dai_link for HDMI > > > ASoC: rockchip_max98090: Add HDMI jack support > > > > > LGTM. > > > > Reviewed-by: Tzung-Bi Shih > > Hi Daniel, > Do you have further concern on this patch series related to hdmi-codec > and drm part ? > We would like to merge this patch series if possible. > They will be needed in many future chrome projects for HDMI audio jack > detection. > Thanks a lot! Hi Neil, I am not sure if this patch series is under your radar. Would you mind taking a look ? This patch series has been following great suggestions from various reviewers, so I hope it is fine now. Audio jack reporting for HDMI might not be needed for other OS, but it is a must on ChromeOS. We have many previous projects using different local patch sets to achieve HDMI jack reporting. I hope that we can achieve a proper way and really get the patches merged to mainline. Thanks a lot! _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel