From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64785C352BE for ; Sat, 18 Apr 2020 19:01:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4BAD21BE5 for ; Sat, 18 Apr 2020 19:01:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="RZbAhxBC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Dab8X2Ct" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4BAD21BE5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 419841616; Sat, 18 Apr 2020 21:00:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 419841616 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587236494; bh=UgXOgSwIMyfiGPkOtWwuniPLy2NcYx/OJ8KMhNGbheM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RZbAhxBCi6Rg4dp6mAbXNYlHSIkbTGgz/YwTvKgAL1jt4uT+be2tzty6d0gGgG0L8 1TQ5R4g3hKldk2BPk8WFMxh7Cm6JAPvlcDvqWuS9jTZyKivqr7fOyFhbGxuWivm24a SpHIB39cAHjaLV+m0lyL3QkAkVMRDRxkYVlCBrGc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C12AAF8013D; Sat, 18 Apr 2020 21:00:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 71E6EF8014E; Sat, 18 Apr 2020 21:00:41 +0200 (CEST) Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BC77AF80122 for ; Sat, 18 Apr 2020 21:00:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BC77AF80122 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Dab8X2Ct" Received: by mail-lf1-x143.google.com with SMTP id f8so4560456lfe.12 for ; Sat, 18 Apr 2020 12:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pJRI8oZ6j+rGEg2+OCymOS7794uvyRZcSR2Htjt5TI4=; b=Dab8X2CtWipiSivi9nyLxp8nBHQpWedKwzW35yNj8kBU3VxCHrB+3Kn5U3rtIjeKoA Lw3k/ndceMaBnN8HktM5POukz2zYdQKxOk+s6N6D5bBob3ys4IoAy4L7IIPc1NiF89LI qpPs2HFFi+SoqSVPJ7yi1QNfgGKP7Teiklti0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pJRI8oZ6j+rGEg2+OCymOS7794uvyRZcSR2Htjt5TI4=; b=evJimkp2r09JYDnCB3pPfbxViogA6rK3LOdCZHWcIfghVU6tj37qjK0mUQxVGU7AAd Xn96Ppabgvq4G2aDL1aCK8Ochs4izZJuA/FYSmrNluLpb2I5XScfaEayivmpEA+yn48u u0+B3X3oadgzDsBIUjtbw/ZYsb4HbZJ9vWSJ9GZX8yTO0aXDBcZFkBhwXK2+4TiIjI+G EbA6hAOlXtxYZfAqnUELhlt9virfeUXmJj3ETwTa5f4OSMPlL8XCbER5dwV8+WrHP5Qd EKEEpDv6QUiSZwppyoRxoF4TGWCNFd4CFL6QMCpxhqvsuf0DqfDfp//7m6yWCLLX8kR1 kgBg== X-Gm-Message-State: AGi0Puadi5kQR/KqL8I3xg0qZ0d49GigcWa98Vg8UErH/Jz7bKheanCF bNsT/3m4WfDxTbKlQhJjmYykmgQJYfk= X-Google-Smtp-Source: APiQypJH6lUa6+Tl/KObD+gTa0fdoSEhLwcd25FR6EMjyAwUG8RwXjWashQau7d7rhKZ0ZyhYuojfg== X-Received: by 2002:ac2:569b:: with SMTP id 27mr5688760lfr.134.1587236432687; Sat, 18 Apr 2020 12:00:32 -0700 (PDT) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com. [209.85.167.50]) by smtp.gmail.com with ESMTPSA id l12sm18455925lfp.35.2020.04.18.12.00.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Apr 2020 12:00:32 -0700 (PDT) Received: by mail-lf1-f50.google.com with SMTP id m2so4562738lfo.6 for ; Sat, 18 Apr 2020 12:00:32 -0700 (PDT) X-Received: by 2002:a05:6512:405:: with SMTP id u5mr5483360lfk.192.1587235998911; Sat, 18 Apr 2020 11:53:18 -0700 (PDT) MIME-Version: 1.0 References: <20200418184111.13401-1-rdunlap@infradead.org> <20200418184111.13401-3-rdunlap@infradead.org> In-Reply-To: <20200418184111.13401-3-rdunlap@infradead.org> From: Linus Torvalds Date: Sat, 18 Apr 2020 11:53:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/9] fs: fix empty-body warning in posix_acl.c To: Randy Dunlap Content-Type: text/plain; charset="UTF-8" Cc: alsa-devel@alsa-project.org, Dmitry Torokhov , Zzy Wysm , Linux Kernel Mailing List , "J. Bruce Fields" , target-devel , Dave Jiang , linux-scsi , linux-nvdimm , Vishal Verma , linux-input@vger.kernel.org, Alexander Viro , Dan Williams , Andrew Morton , "open list:NFS, SUNRPC, AND..." , "Martin K. Petersen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Takashi Iwai , Chuck Lever , linux-fsdevel , Johannes Berg X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, Apr 18, 2020 at 11:41 AM Randy Dunlap wrote: > > Fix gcc empty-body warning when -Wextra is used: Please don't do this. First off, "do_empty()" adds nothing but confusion. Now it syntactically looks like it does something, and it's a new pattern to everybody. I've never seen it before. Secondly, even if we were to do this, then the patch would be wrong: > if (cmpxchg(p, ACL_NOT_CACHED, sentinel) != ACL_NOT_CACHED) > - /* fall through */ ; > + do_empty(); /* fall through */ That comment made little sense before, but it makes _no_ sense now. What fall-through? I'm guessing it meant to say "nothing", and somebody was confused. With "do_empty()", it's even more confusing. Thirdly, there's a *reason* why "-Wextra" isn't used. The warnings enabled by -Wextra are usually complete garbage, and trying to fix them often makes the code worse. Exactly like here. Linus