Re: [PATCH] Fix kbl_rt5663_rt5514_max98927 regression

[Jason Montleon <jmontleo@redhat.com>]

Thanks all for the feedback. I've adjusted the commit message as
asked, and updated rt5677-spi as well. From what I think I can see in
past commits it looks like separate drivers are done with separate
commits/patches. I didn't see any additional comments whether
endianness should or shouldn't also be set so I left it off. I can
make another updated if necessary.

I apologize if I'm mucking it up, This is my first kernel patch,
trying to follow along and do things right.

On Thu, Nov 3, 2022 at 7:14 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Thu, 03 Nov 2022 10:54:04 +0100,
> Charles Keepax wrote:
> >
> > On Thu, Nov 03, 2022 at 08:59:03AM +0100, Takashi Iwai wrote:
> > > On Wed, 02 Nov 2022 23:05:14 +0100,
> > > Pierre-Louis Bossart wrote:
> > > >
> > > > On 11/2/22 16:05, Jason Montleon wrote:
> > > > > Starting with 6.0-rc1 these messages are logged and the sound card
> > > > > is unavailable. Adding legacy_dai_naming to the rt5514-spi causes
> > > > > it to function properly again.
> > > > >
> > > > > [   16.928454] kbl_r5514_5663_max kbl_r5514_5663_max: ASoC: CPU DAI
> > > > > spi-PRP0001:00 not registered
> > > > > [   16.928561] platform kbl_r5514_5663_max: deferred probe pending
> > > >
> > > > Thanks for reporting this regression, much appreciated.
> > > >
> > > > a) you need to CC: maintainers Mark Brown and Takashi Iwai
> > > > b) the commit title should be something like "ASoC: rt5514: fix legacy
> > > > dai naming".
> > > > c) it's not clear if this is actually enough. there's no
> > > > legacy_dai_naming for e.g. rt5663 and the .endianness member is not set.
> > >
> > > IIUC, rt5663.c should be fine; it used to have non_legacy_dai_naming
> > > flag and it was dropped after the switch.
> > >
> > > But, through a quick glance, rt5677-spi.c seems to be the same pattern
> > > as rt5514-spi.c.  The rt5677.c was covered properly but the *-spi.c
> > > wan't.
> > >
> >
> > Yeah I think these got missed as they are effectively CPU side
> > devices but living in the CODEC space. Looks like it would be
> > reasonable to add legacy_dai_naming to both of them to me.
>
> BTW, the bug was reported on bugzilla:
>   https://bugzilla.kernel.org/show_bug.cgi?id=216641
>
> Please respond on there and add the link to the fix patch, too.
>
>
> thanks,
>
> Takashi
>
> >
> > Thanks,
> > Charles
> >
> > > > >  static const struct snd_soc_component_driver rt5514_spi_component = {
> > > > > -       .name           = DRV_NAME,
> > > > > -       .probe          = rt5514_spi_pcm_probe,
> > > > > -       .open           = rt5514_spi_pcm_open,
> > > > > -       .hw_params      = rt5514_spi_hw_params,
> > > > > -       .hw_free        = rt5514_spi_hw_free,
> > > > > -       .pointer        = rt5514_spi_pcm_pointer,
> > > > > -       .pcm_construct  = rt5514_spi_pcm_new,
> > > > > +       .name                   = DRV_NAME,
> > > > > +       .probe                  = rt5514_spi_pcm_probe,
> > > > > +       .open                   = rt5514_spi_pcm_open,
> > > > > +       .hw_params              = rt5514_spi_hw_params,
> > > > > +       .hw_free                = rt5514_spi_hw_free,
> > > > > +       .pointer                = rt5514_spi_pcm_pointer,
> > > > > +       .pcm_construct          = rt5514_spi_pcm_new,
> > > > > +       .legacy_dai_naming      = 1,
> > > > >  };
> > > > >
> > > > >  /**
> > > >
> >
>


-- 
Jason Montleon        | email: jmontleo@redhat.com
Red Hat, Inc.         | gpg key: 0x069E3022
Cell: 508-496-0663    | irc: jmontleo / jmontleon