From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAFAFC2BA83 for ; Fri, 14 Feb 2020 07:56:05 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6649620675 for ; Fri, 14 Feb 2020 07:56:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Fk3whtw9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nO8VWAnq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6649620675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BF284167C; Fri, 14 Feb 2020 08:55:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BF284167C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581666963; bh=pUR7yZkFqwVpj2i4Ie447uHP1oj5FAd2uV+g638eG78=; h=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Fk3whtw9yFqAoWFzpOnjP3wmXM+XVK3y7++0om0AqBhXvetaYnsNsCn8IM8Qo7o22 lUFu9yrCq2BizZpCtOd37RYCThnY4Fm7mCO7icME28ap9VDGqlIfG05uZEqWpuOPoL Kj2YFc3PjmXEzV/ZoI94lHsc+sm3+nplT5ceed34= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AC48EF8019B; Fri, 14 Feb 2020 08:54:42 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 93E66F80228; Fri, 14 Feb 2020 08:54:41 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F278BF80158 for ; Fri, 14 Feb 2020 08:54:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F278BF80158 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nO8VWAnq" Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C21F024673 for ; Fri, 14 Feb 2020 07:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581666876; bh=uUqCY41ymz6hiHKzFlEzisjq83c9h686/Ry4dcKtL8o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nO8VWAnq6enkWoVO1KQOYen9dfbnv11SjtbXp+5e9AWrErsEw2EGJzm9oxQUQQj5b GTGWK9hnefBoQm7ycijq0ujxWXUHB2dkpOXCXZq69cSbfBPP9lVazagzVCiSWZnZRh JiDRfIdqXWtwoYtPWpK9YWF4OeGkaWHDqt9+6+t0= Received: by mail-lj1-f178.google.com with SMTP id y6so9664777lji.0 for ; Thu, 13 Feb 2020 23:54:35 -0800 (PST) X-Gm-Message-State: APjAAAXz7/dEbGFoBpH6NBfnqS5v51u/miRJoqCGI3qhVa5qR32MiHGs Kn226g7y25wa7LjIhlAbLQ5jBgeS27LZAZf4maw= X-Google-Smtp-Source: APXvYqxYBogvyVwCKY0O00NON1CcUeROLB0hSLARDR8eSX50Ch0burvTbanjgmW65jT/Dd4xwcQQTYXH4O/btXWthPQ= X-Received: by 2002:a2e:9a11:: with SMTP id o17mr1196010lji.256.1581666873795; Thu, 13 Feb 2020 23:54:33 -0800 (PST) MIME-Version: 1.0 References: <20200210061544.7600-1-yuehaibing@huawei.com> <9351a746-8823-ee26-70da-fd3127a02c91@linux.intel.com> In-Reply-To: From: Krzysztof Kozlowski Date: Fri, 14 Feb 2020 08:54:21 +0100 X-Gmail-Original-Message-ID: Message-ID: To: Daniel Baluta Cc: Daniel Baluta , Pierre-Louis Bossart , Linux-ALSA , Liam Girdwood , Fabio Estevam , Sascha Hauer , Yuehaibing , Takashi Iwai , Mark Brown , dl-linux-imx , Pengutronix Kernel Team , Shawn Guo , Linux Kernel Mailing List , linux-arm-kernel Subject: Re: [alsa-devel] [PATCH -next] ASoC: SOF: imx8: Fix randbuild error X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 13 Feb 2020 at 22:12, Daniel Baluta wrote: > > > > Visible symbols usually should not be selected. The same with symbols > > with dependencies. The docs have this rule mentioned. > > You mean if module X depends on module Y, we shouldn't use select? > But this exactly what this patch does :). There are two different cases (hints against using select): 1. select A, if A is a user-visible (possible to select) option, 2. select only A if A depends on B (and B is kind of independent). These cases are discouraged. > The problem here is that when X depends on Y, and X=y and Y=m > when we try to compile X if get an error because we cannot find a symbol from Y. > > I think if X depends on Y, and X is forced to "y" then also Y should > be forced on "y". If X is bool, then depends should be =y. If X is tristate, then probably you need something like: depends (Y!=m || m) There is also solution like: config CEPH_FSCACHE depends on CEPH_FS=m && FSCACHE || CEPH_FS=y && FSCACHE=y but it works if the upper-level option (CEPH_FS) is a tristate. Best regards, Krzysztof _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel