From: Masahiro Yamada <masahiroy@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [alsa-devel] [PATCH] [RFC] ASoC: Use imply for SND_SOC_ALL_CODECS
Date: Wed, 12 Feb 2020 01:38:16 +0900 [thread overview]
Message-ID: <CAK7LNARCr8afvs=h5-ZWVs=Bkk7PSMNvX+M_SeBSF-L99UencA@mail.gmail.com> (raw)
In-Reply-To: <20200211161905.GM4543@sirena.org.uk>
On Wed, Feb 12, 2020 at 1:19 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Feb 12, 2020 at 01:09:30AM +0900, Masahiro Yamada wrote:
>
> > Why does SND_SOC_ALL_CODECS exist in the first place?
> > Is this compile-test or run-test?
>
> It's for compile coverage.
>
> > If it is the former, allyesconfig / allmodconfig
> > covers all of them.
>
> No it doesn't. Those only enable user selectable options, many CODEC
> drivers don't have user selectable options as they are selected by
> machine drivers some of which either have more platform specific
> dependencies that the CODEC drivers or aren't upstream.
Maybe, can you add a prompt which is only displayed
if COMPILE_TEST is enabled?
For example,
config SND_SOC_L3
tristate "some prompt" if COMPILE_TEST
In normal use-cases, this CONFIG option is hidden
since we expect it to be selected by some machine options.
If COMPILE_TEST is enabled, we can toggle as you like.
If I run
$ git grep "if COMPILE_TEST"
I see many usages of this tip.
--
Best Regards
Masahiro Yamada
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-02-11 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 9:13 [alsa-devel] [PATCH] [RFC] ASoC: Use imply for SND_SOC_ALL_CODECS Geert Uytterhoeven
2020-02-10 14:03 ` Mark Brown
2020-02-11 15:49 ` [alsa-devel] Applied "ASoC: Use imply for SND_SOC_ALL_CODECS" to the asoc tree Mark Brown
2020-02-11 16:09 ` [alsa-devel] [PATCH] [RFC] ASoC: Use imply for SND_SOC_ALL_CODECS Masahiro Yamada
2020-02-11 16:19 ` Mark Brown
2020-02-11 16:38 ` Masahiro Yamada [this message]
2020-02-11 16:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNARCr8afvs=h5-ZWVs=Bkk7PSMNvX+M_SeBSF-L99UencA@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).