From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21693C43331 for ; Fri, 6 Sep 2019 11:57:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2061520854 for ; Fri, 6 Sep 2019 11:57:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="aJ2q1hRw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2061520854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CF88074C; Fri, 6 Sep 2019 13:56:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CF88074C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1567771059; bh=xOKas7d/dEwRdERPnpqEQp9TaQ1ggkiLFO/cYoBoeQ0=; h=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=aJ2q1hRwhWO98nCPRLG6fKSkAnue/YDKKDPOxka1xW206/6As/GC7diTivbvWAI0I WOeQUgU6X6IkaWLLiY6BRL3JNjfplxNFuwysDTJLbbCPx6vAPYDuIAWJArcjUBWigG 4w4WAwr6J1sUYV5KelTAd5yTUYvFk0PnXTdyJ8j0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 01E19F80390; Fri, 6 Sep 2019 13:56:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 74BBDF80394; Fri, 6 Sep 2019 13:56:47 +0200 (CEST) Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5A19BF80214 for ; Fri, 6 Sep 2019 13:56:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5A19BF80214 Received: by mail-qk1-f194.google.com with SMTP id u184so2396693qkd.4 for ; Fri, 06 Sep 2019 04:56:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7F1mUtKY856FJCLvPUe7oWqK5RgOugdtEGZ/H9fzbmY=; b=nMAYbHP8/eMKE9jgpdSyF/unFAN53WGwRrGlrXAkKMtFEorLbYB12BX9TJ2Bk0S7v9 FEBRtdqlk12C05voL7MUT+cfLNhv9kXA2rVj6dohfRTOCAEl185ClOrD16Upsi0sfYZf uRz6pqA2mJLW4dLyfY5PIsTTbN3z1uOKW+rSLaJ+AzXWJIKOog1SrNu6Igo8ONCmSC/2 llPrbaNCnoVPe7Gt5JgdNHWSdJyNM6pv+S75hFR7Kky0Pholl4hD2YSS0TbW+vIKHVqO am96z297uNsa/K6IXiprTIYuR64fguwtjQ7AllL7e5d3Iq/bO7oNeOIMl+AUDhYbjsQ8 H3VQ== X-Gm-Message-State: APjAAAVVTO5SDcz4WZdTWdzKF6h9yY/qGY7ZDKZHNpSgirMp7dnA3auX XvhGxPX6AjvRsGA1wc7Nx0QnlmZFe+8kPMYTu/I= X-Google-Smtp-Source: APXvYqzwhelhrJw6v97UlvQ9gFA+EJEgAwG1lBZjHPuhlD2jF5AyUyvgcLeKKXFPoQHWEZjaqubrLx7rtowyRq2juOc= X-Received: by 2002:ae9:ef8c:: with SMTP id d134mr8236616qkg.286.1567771002514; Fri, 06 Sep 2019 04:56:42 -0700 (PDT) MIME-Version: 1.0 References: <20190905203527.1478314-1-arnd@arndb.de> <20190906043805.GE2672@vkoul-mobl> <20190906104403.GH2672@vkoul-mobl> In-Reply-To: <20190906104403.GH2672@vkoul-mobl> From: Arnd Bergmann Date: Fri, 6 Sep 2019 13:56:26 +0200 Message-ID: To: Vinod Koul Cc: Takashi Iwai , Sanyog Kale , Pierre-Louis Bossart , ALSA Development Mailing List , "linux-kernel@vger.kernel.org" Subject: Re: [alsa-devel] [PATCH] soundwire: add back ACPI dependency X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Sep 6, 2019 at 12:45 PM Vinod Koul wrote: > On 06-09-19, 12:02, Arnd Bergmann wrote: > > On Fri, Sep 6, 2019 at 6:39 AM Vinod Koul wrote: > > > > > > On 05-09-19, 22:35, Arnd Bergmann wrote: > > > > Soundwire gained a warning for randconfig builds without > > > > CONFIG_ACPI during the linux-5.3-rc cycle: > > > > > > > > drivers/soundwire/slave.c:16:12: error: unused function 'sdw_slave_add' [-Werror,-Wunused-function] > > > > > > > > Add the CONFIG_ACPI dependency at the top level now. > > > > > > Did you run this yesterday or today. I have applied Srini's patches to > > > add DT support for Soundwire couple of days back so we should not see > > > this warning anymore > > > > This is on the latest linux-next, which is dated 20190904. As Stephen is > > not releasing any more linux-next kernels until later this month, I'm > > missing anything that came in afterwards. > > That is interesting as next-20190904 has the DT changes :) Can you share > the config you used to get this. > > I have two instances of sdw_slave_add() in next-20190904: > > drivers/soundwire/slave.c: sdw_slave_add(bus, &id, acpi_fwnode_handle(adev)); > drivers/soundwire/slave.c: sdw_slave_add(bus, &id, of_fwnode_handle(node)); Ok, I remember now: the warning I got was actually on mainline. It's fixed in linux-next, but from all I can tell, 5.3-rc7 is still broken. Arnd _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel