From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 035F4C433E0 for ; Tue, 30 Jun 2020 22:23:42 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73A912072D for ; Tue, 30 Jun 2020 22:23:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="O5XQVZeZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="d9za7jNT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73A912072D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F3B2483A; Wed, 1 Jul 2020 00:22:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F3B2483A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1593555820; bh=tLQScyH3DkTRMoOo7z4ZDKGZgpJVuuj0dCkLOX2a9iE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=O5XQVZeZxNZ11tScxeNFJe1oo1NGS2Vz+HwkQMgk9iM6lDKGGr95KYNTurPvCphPb qVBvJd26rqGTrzyQ6N9mCF71J2PHF85wEVbVqtJW8uR6W2oQJs1T2zyKSrsdiNInqR OnRPMY1tNunb0WyAaBW1duZ7EmdG/+h647ssIzjQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 70B4BF801F2; Wed, 1 Jul 2020 00:22:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3DB27F801F2; Wed, 1 Jul 2020 00:22:48 +0200 (CEST) Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CE14AF8013E for ; Wed, 1 Jul 2020 00:22:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CE14AF8013E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="d9za7jNT" Received: by mail-pl1-x641.google.com with SMTP id o1so2490620plk.1 for ; Tue, 30 Jun 2020 15:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LQqg1+PZ05kIBpTL59xr7DfetEZhJfx8+ch9+gI56hE=; b=d9za7jNTCujMATufanAoR3E/dGN4JlmvT8hTxlO3BqAzmpkcLMzyenbVFNE04cO5Eq V3DgKPCKI5KwKtKe/Lm6L4L/ke5Q1Y/bNin6Ta4aYPvb9AaDyLgHaKCQ7/bhBAiCY10J 9Qtuq+KjVh4r1/3OeWVh3VEZtFTmImFJLF8MdDLDnxQcdIDSfkzSD2QUF1q5FRBXynKF chtp2UHDgw7EWxu56qD6JK+Wh1bOkY5o1Jz+mh76bbPcfik3Bh6qpYuwVzpDL+A70zpI 0X2X1Agp2iaiaf2DoXiqE+EKqkqHPYLKjJw2dd7rDpioCCC36NnjhlW+gvz+y3oK0sju 4qnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LQqg1+PZ05kIBpTL59xr7DfetEZhJfx8+ch9+gI56hE=; b=bGUlQG9fgx1Qz2YJNVOC1ch0zkbLCUNnWaPAyWlmwdFCaom5c+HGzYPWuVDprxRLae gVAn34YbiyCNvYP6cKPl5DdmlA67GNjkuvZagg+m3io1DgS3a23o7sKY7JIuSYn5foa5 R8sa5caETOtVOLPvlTU7yWJVHaRmB1H1Qzq3HsElafVfl/zdZ9sLOzoEj2IGm8ltA3Xd yQ7NYUgRn4f1j37e/Lbk8lUL1ytLFxWHmqg+mvkmYPvSKcgszFKbvtx0StmlYx5cQbR2 r1Nok3L33r/L5ehPzgvrnnywaVldrml99aLTjKuktmi0JTt7S83HoIQwd0WfricFncub 3BBw== X-Gm-Message-State: AOAM531i7KIhj6HttwiTFnGp8JTjMef2Trp4KnOGEP2TkC4asMpTVQfI NXszU5qoeizXKXiyKtaLhidGPeqVSDaCyNv+YzKGFcuG X-Google-Smtp-Source: ABdhPJxCBS34d/ACfckTMdJK3GubMe09aLA2YT2TUi4myE/v1ISodfMaY3nIq1O/4bK4VRpBoPPYs9LPzxwrE6TH1wo= X-Received: by 2002:a17:90a:1e:: with SMTP id 30mr23028159pja.25.1593555757877; Tue, 30 Jun 2020 15:22:37 -0700 (PDT) MIME-Version: 1.0 References: <20200617010232.23222-1-natechancellor@gmail.com> In-Reply-To: <20200617010232.23222-1-natechancellor@gmail.com> From: Nick Desaulniers Date: Tue, 30 Jun 2020 15:22:25 -0700 Message-ID: Subject: Re: [PATCH] ASoC: Intel: KeemBay: Fix header guard To: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang Content-Type: text/plain; charset="UTF-8" Cc: alsa-devel@alsa-project.org, LKML , Sia Jee Heng , clang-built-linux , Mark Brown , Nathan Chancellor X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Jun 16, 2020 at 6:02 PM Nathan Chancellor wrote: > > Clang warns: > > In file included from sound/soc/intel/keembay/kmb_platform.c:14: > sound/soc/intel/keembay/kmb_platform.h:9:9: warning: 'KMB_PLATFORM_H_' > is used as a header guard here, followed by #define of a different > macro [-Wheader-guard] > #ifndef KMB_PLATFORM_H_ > ^~~~~~~~~~~~~~~ > sound/soc/intel/keembay/kmb_platform.h:10:9: note: 'KMB_PLATFORMP_H_' > is defined here; did you mean 'KMB_PLATFORM_H_'? > #define KMB_PLATFORMP_H_ > ^~~~~~~~~~~~~~~~ > KMB_PLATFORM_H_ > 1 warning generated. > > Fix the typo so that the header guard works as intended. > > Fixes: c5477e966728 ("ASoC: Intel: Add KeemBay platform driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/1053 > Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desaulniers > --- > sound/soc/intel/keembay/kmb_platform.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/keembay/kmb_platform.h b/sound/soc/intel/keembay/kmb_platform.h > index 29600652d8f4..6bf221aa8fff 100644 > --- a/sound/soc/intel/keembay/kmb_platform.h > +++ b/sound/soc/intel/keembay/kmb_platform.h > @@ -7,7 +7,7 @@ > */ > > #ifndef KMB_PLATFORM_H_ > -#define KMB_PLATFORMP_H_ > +#define KMB_PLATFORM_H_ > > #include > #include > > base-commit: 27f70ec4fa0e0f419031f1b8d61b1a788244e313 > -- > 2.27.0 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200617010232.23222-1-natechancellor%40gmail.com. -- Thanks, ~Nick Desaulniers