From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C49FFECE588 for ; Tue, 15 Oct 2019 11:36:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6DA921848 for ; Tue, 15 Oct 2019 11:36:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="uifziFPF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="G0WeyfkM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6DA921848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0D4C1844; Tue, 15 Oct 2019 13:35:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0D4C1844 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1571139370; bh=opw/5SmWBDlxGgqbg25NPU6J6X1eW5ddYsULni2Satk=; h=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uifziFPFX4RvU1vuRdx3lWkpVXdXZm9qhVIPkIgvjP+G86jAAFty7/IeOyPg2D37G /vPjSPGHmpUcdfx8Px+3FId9mvIT4Hf1vKTBJ5WC9pYsQiEoTltEvZqsWfSa8NVqc8 B4a7dx330YoKNC7Q1unzV/9g75vHcE8+rmxts2TU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8E604F804A9; Tue, 15 Oct 2019 13:35:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 47C64F804AA; Tue, 15 Oct 2019 13:35:18 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8B48AF800F4 for ; Tue, 15 Oct 2019 13:35:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8B48AF800F4 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="G0WeyfkM" Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0033621D7D for ; Tue, 15 Oct 2019 11:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571139312; bh=RmwTSDIV8FwauP/TKSSY3ZDlw7e1niXdhbfrZ3cn/3U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=G0WeyfkMI8DUD6k61eGb9P15FohcAbMve2CgAE71mA3q0NuhSFaIOCYWT+ANYz48D j7UQl8M4Uc8QXB/vzKMB3Uu3pUcir3dR6wceFeR5ZYk5hNrvxA7JsCU/pOj6LX1Ft8 EsI3IjAGOKwQBxelIRslQ/SWxt142ZO17244Iohg= Received: by mail-qt1-f178.google.com with SMTP id o12so30044533qtf.3 for ; Tue, 15 Oct 2019 04:35:11 -0700 (PDT) X-Gm-Message-State: APjAAAURE7MTdr1RW7LZxsbtWkZ9bBonsp9kk1Lq27R6pIF8muPlPm74 5AbjFd+qOpR47DP3AtGVz3atV7FNfQyM/w7JKw== X-Google-Smtp-Source: APXvYqwV4ka+h8Ai6FzlPXTB/SteBHk/rshSYgJyQG3n6WwcEMODovifEQMVxtQT5VJ5SFVHSgIdavwnJcXTiUug4Fg= X-Received: by 2002:ac8:44d9:: with SMTP id b25mr39135730qto.300.1571139311121; Tue, 15 Oct 2019 04:35:11 -0700 (PDT) MIME-Version: 1.0 References: <20191011154423.2506-1-srinivas.kandagatla@linaro.org> <20191011154423.2506-2-srinivas.kandagatla@linaro.org> <20191014171241.GA24989@bogus> <76be1a0d-43ea-44c3-ef6c-9f9a2025c7a2@linaro.org> In-Reply-To: <76be1a0d-43ea-44c3-ef6c-9f9a2025c7a2@linaro.org> From: Rob Herring Date: Tue, 15 Oct 2019 06:35:00 -0500 X-Gmail-Original-Message-ID: Message-ID: To: Srinivas Kandagatla Cc: devicetree@vger.kernel.org, Linux-ALSA , Banajit Goswami , "linux-kernel@vger.kernel.org" , spapothi@codeaurora.org, Pierre-Louis Bossart , Liam Girdwood , Vinod , Mark Brown Subject: Re: [alsa-devel] [PATCH v3 1/2] dt-bindings: soundwire: add bindings for Qcom controller X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Oct 14, 2019 at 12:34 PM Srinivas Kandagatla wrote: > > Thanks Rob for taking time to review, > > On 14/10/2019 18:12, Rob Herring wrote: > > On Fri, Oct 11, 2019 at 04:44:22PM +0100, Srinivas Kandagatla wrote: > >> This patch adds bindings for Qualcomm soundwire controller. > >> > >> Qualcomm SoundWire Master controller is present in most Qualcomm SoCs > >> either integrated as part of WCD audio codecs via slimbus or > >> as part of SOC I/O. > >> > >> Signed-off-by: Srinivas Kandagatla > >> --- > >> .../bindings/soundwire/qcom,sdw.txt | 167 ++++++++++++++++++ > >> 1 file changed, 167 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/soundwire/qcom,sdw.txt > > > > Next time, do a DT schema. > > > Sure! I can do that in next version! I meant the next binding you write, not v4. However, ... [...] > >> += SoundWire devices > >> +Each subnode of the bus represents SoundWire device attached to it. > >> +The properties of these nodes are defined by the individual bindings. > > > > Is there some sort of addressing that needs to be defined? > > > Thanks, Looks like I missed that here. > > it should be something like this, > > #address-cells = <2>; > #size-cells = <0>; > > Will add the in next version. You need a common soundwire binding for this. You also need to define the format of 'reg' and unit addresses. And it needs to be a schema. So perhaps this binding too should be. Rob _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel