Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Linux-ALSA <alsa-devel@alsa-project.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [alsa-devel] [PATCH v3 2/2] dt-bindings: asoc: Add ADAU7118 documentation
Date: Fri, 11 Oct 2019 14:01:16 -0500
Message-ID: <CAL_JsqJu06hW-VRGZ4nFx6TYtf3yVJezUVhCSyTjP+qPmG7+Gw@mail.gmail.com> (raw)
In-Reply-To: <20191010210850.GA20184@bogus>

On Thu, Oct 10, 2019 at 4:08 PM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Oct 10, 2019 at 09:42:34AM +0200, Nuno Sá wrote:
> > Document the ADAU7118 8 channel PDM to I2S/TDM converter devicetree
> > bindings.
> >
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > Changes in v2:
> >  * List regulators as required;
> >
> > Changes in v3:
> >  * Set the correct license for new bindings.
> >
> >  .../bindings/sound/adi,adau7118.yaml          | 90 +++++++++++++++++++
> >  1 file changed, 90 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/sound/adi,adau7118.yaml

Looks like Mark already applied this. Please send a follow-up patch
addressing my comments.

> >
> > diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> > new file mode 100644
> > index 000000000000..cfcef602b3d9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> > @@ -0,0 +1,90 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/adi,adau7118.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +
> > +title: Analog Devices ADAU7118 8 Channel PDM to I2S/TDM Converter
> > +
> > +maintainers:
> > +  - Nuno Sá <nuno.sa@analog.com>
> > +
> > +description: |
> > +  Analog Devices ADAU7118 8 Channel PDM to I2S/TDM Converter over I2C or HW
> > +  standalone mode.
> > +  https://www.analog.com/media/en/technical-documentation/data-sheets/ADAU7118.pdf
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,adau7118
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  "#sound-dai-cells":
> > +    const: 0
> > +
> > +  IOVDD-supply:
>
> Use lowercase please.
>
> > +    description: Digital Input/Output Power Supply.
> > +    $ref: "/schemas/types.yaml#/definitions/phandle"
>
> *-supply already has a type, so just a description is enough.
>
> > +
> > +  DVDD-supply:
> > +    description: Internal Core Digital Power Supply.
> > +    $ref: "/schemas/types.yaml#/definitions/phandle"
>
> Same here.
>
> > +
> > +  adi,decimation-ratio:
> > +    description: |
> > +      This property set's the decimation ratio of PDM to PCM audio data.
> > +    allOf:
> > +      - $ref: /schemas/types.yaml#/definitions/uint32
> > +      - enum: [64, 32, 16]
> > +        default: 64
> > +
> > +  adi,pdm-clk-map:
> > +    description: |
> > +      The ADAU7118 has two PDM clocks for the four Inputs. Each input must be
> > +      assigned to one of these two clocks. This property set's the mapping
> > +      between the clocks and the inputs.
> > +    allOf:
> > +      - $ref: /schemas/types.yaml#/definitions/uint32-array
> > +      - minItems: 4
> > +        maxItems: 4
> > +        items:
> > +          maximum: 1
> > +        default: [0, 0, 1, 1]
> > +
> > +required:
> > +  - "#sound-dai-cells"
> > +  - compatible
> > +  - IOVDD-supply
> > +  - DVDD-supply
> > +
> > +examples:
> > +  - |
> > +    i2c0 {
>
> i2c {
>
> > +        /* example with i2c support */
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        status = "okay";
>
> Don't show status in examples.
>
> > +        adau7118_codec: adau7118-codec@14 {
>
> audio-codec@14
>
> > +                compatible = "adi,adau7118";
> > +                reg = <14>;
> > +                #sound-dai-cells = <0>;
> > +                status = "okay";
> > +                IOVDD-supply = <&supply>;
> > +                DVDD-supply = <&supply>;
> > +                adi,pdm-clk-map = <1 1 0 0>;
> > +                adi,decimation-ratio = <16>;
> > +        };
> > +    };
> > +
> > +    /* example with hw standalone mode */
> > +    adau7118_codec_hw: adau7118-codec-hw {
> > +            compatible = "adi,adau7118";
> > +            #sound-dai-cells = <0>;
> > +            status = "okay";
> > +            IOVDD-supply = <&supply>;
> > +            DVDD-supply = <&supply>;
> > +    };
> > --
> > 2.23.0
> >
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10  7:42 [alsa-devel] [PATCH v3 1/2] ASOC: Add ADAU7118 8 Channel PDM-to-I2S/TDM Converter driver Nuno Sá
2019-10-10  7:42 ` [alsa-devel] [PATCH v3 2/2] dt-bindings: asoc: Add ADAU7118 documentation Nuno Sá
2019-10-10 21:08   ` Rob Herring
2019-10-11 19:01     ` Rob Herring [this message]
2019-10-10 14:05 ` [alsa-devel] [PATCH v3 1/2] ASOC: Add ADAU7118 8 Channel PDM-to-I2S/TDM Converter driver Mark Brown
2019-10-10 15:05   ` Sa, Nuno
2019-10-10 15:36     ` Mark Brown
2019-10-11  7:03       ` Sa, Nuno

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqJu06hW-VRGZ4nFx6TYtf3yVJezUVhCSyTjP+qPmG7+Gw@mail.gmail.com \
    --to=robh@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=nuno.sa@analog.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org alsa-devel@archiver.kernel.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox