From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CEC4C433DF for ; Fri, 14 Aug 2020 14:52:45 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B93220885 for ; Fri, 14 Aug 2020 14:52:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="lGYw63rU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bjfRL+mB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B93220885 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 056671657; Fri, 14 Aug 2020 16:51:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 056671657 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1597416763; bh=2azDCJAW0WmwzjFoNP1+Xf1baXp64Ykp/VUpBlKju0s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lGYw63rUqSn12Th2Y2bDxMEMyD3zwFfICzD+wh9v6Sjs9TkMNExtarKt2eweWUUfD QP67Wsh2yPY8EscBRF3h8MVCD9eqkBAUbm2CQlj82J5yZ00cNnIsYQOagkv59ZOsJ4 4S6bHY8Uv2fE776z4dpc/WxCZPIgyoGlNzPfoSl4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7B1B3F80146; Fri, 14 Aug 2020 16:51:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A254FF8022B; Fri, 14 Aug 2020 16:51:50 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 33702F80146 for ; Fri, 14 Aug 2020 16:51:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 33702F80146 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bjfRL+mB" Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA1D620866 for ; Fri, 14 Aug 2020 14:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597416697; bh=2azDCJAW0WmwzjFoNP1+Xf1baXp64Ykp/VUpBlKju0s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bjfRL+mBKQdeXNIPuXX+sib3fYs2/XZWJHPOjPd4x196xwXtWkEnxkwGCGKCP+vXy CxGeqKP68MgYI300g+hNTJd4uQCvZb/zOsnBdJ/cEKlyynKbLGyhuMbkA+R9Y9MLDY rajai6Sqx8HGb8L035zTD4t0BSpxCLooD+BQeHTA= Received: by mail-ot1-f53.google.com with SMTP id 93so7770353otx.2 for ; Fri, 14 Aug 2020 07:51:36 -0700 (PDT) X-Gm-Message-State: AOAM530A5fH84+GDNZDqZeMfsw1Qnudi022zX2ZQe+cuv40j0PeExAlY RnXj7tBoHiRzirS+M1RHGb06AHfFj8RB+HRjgw== X-Google-Smtp-Source: ABdhPJzAQOVgwIRLTeJz+4kS8jI7uSM4yy2bV/QUkiEz2152JH8sgfiQxJMSY+wk4abg95jsoFr6h5Ymz6ZJoeFhB2g= X-Received: by 2002:a05:6830:1b79:: with SMTP id d25mr1995774ote.107.1597416696235; Fri, 14 Aug 2020 07:51:36 -0700 (PDT) MIME-Version: 1.0 References: <20200812203618.2656699-1-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Fri, 14 Aug 2020 08:51:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files To: Luca Ceresoli Content-Type: text/plain; charset="UTF-8" Cc: Linux Fbdev development list , "open list:IIO SUBSYSTEM AND DRIVERS" , "open list:REMOTE PROCESSOR \(REMOTEPROC\) SUBSYSTEM" , Linux-ALSA , dri-devel , MTD Maling List , Linux I2C , linux-clk , "open list:REAL TIME CLOCK \(RTC\) SUBSYSTEM" , "open list:SERIAL DRIVERS" , Linux Input , Linux Media Mailing List , devicetree@vger.kernel.org, "open list:THERMAL" , "open list:GPIO SUBSYSTEM" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Linux HWMON List , netdev , Linux USB List , linux-mmc , "linux-kernel@vger.kernel.org" , linux-spi X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Aug 13, 2020 at 4:31 AM Luca Ceresoli wrote: > > Hi Rob, > > On 12/08/20 22:36, Rob Herring wrote: > > Clean-up incorrect indentation, extra spaces, long lines, and missing > > EOF newline in schema files. Most of the clean-ups are for list > > indentation which should always be 2 spaces more than the preceding > > keyword. > > > > Found with yamllint (which I plan to integrate into the checks). > > [...] > > > diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > index 3d4e1685cc55..28c6461b9a9a 100644 > > --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml > > @@ -95,10 +95,10 @@ allOf: > > # Devices without builtin crystal > > properties: > > clock-names: > > - minItems: 1 > > - maxItems: 2 > > - items: > > - enum: [ xin, clkin ] > > + minItems: 1 > > + maxItems: 2 > > + items: > > + enum: [ xin, clkin ] > > clocks: > > minItems: 1 > > maxItems: 2 > > Thanks for noticing, LGTM. > > [...] > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml > > index d7dac16a3960..36dc7b56a453 100644 > > --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml > > +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml > > @@ -33,8 +33,8 @@ properties: > > $ref: /schemas/types.yaml#/definitions/uint32 > > > > touchscreen-min-pressure: > > - description: minimum pressure on the touchscreen to be achieved in order for the > > - touchscreen driver to report a touch event. > > + description: minimum pressure on the touchscreen to be achieved in order > > + for the touchscreen driver to report a touch event. > > Out of personal taste, I find the original layout more pleasant and > readable. This third option is also good, especially for long descriptions: > > description: > minimum pressure on the touchscreen to be achieved in order for the > touchscreen driver to report a touch event. > > At first glance yamllint seems to support exactly these two by default: > > > With indentation: {spaces: 4, check-multi-line-strings: true} Turning on check-multi-line-strings results in 10K+ warnings, so no. The other issue is the style ruamel.yaml wants to write out is as the patch does above. This matters when doing some scripted transformations where we read in the files and write them back out. I can somewhat work around that by first doing a pass with no changes and then another pass with the actual changes, but that's completely scriptable. Hopefully, ruamel learns to preserve the style better. Rob