From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 05/10] clkdev: add clkdev_create() helper Date: Mon, 2 Mar 2015 18:22:31 +0100 Message-ID: References: <20150302170538.GQ8656@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Russell King Cc: ALSA Development Mailing List , "linux-arm-kernel@lists.infradead.org" , Linux Media Mailing List , "linux-omap@vger.kernel.org" , Linux-sh list List-Id: alsa-devel@alsa-project.org On Mon, Mar 2, 2015 at 6:06 PM, Russell King wrote: > --- a/include/linux/clkdev.h > +++ b/include/linux/clkdev.h > @@ -37,6 +37,9 @@ struct clk_lookup *clkdev_alloc(struct clk *clk, const char *con_id, > void clkdev_add(struct clk_lookup *cl); > void clkdev_drop(struct clk_lookup *cl); > > +struct clk_lookup *clkdev_create(struct clk *clk, const char *con_id, > + const char *dev_fmt, ...); __printf(3, 4) While you're at it, can you please also add the __printf attribute to clkdev_alloc() and clk_register_clkdev()? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds