From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A473C54FD0 for ; Fri, 24 Apr 2020 15:22:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1035A206D7 for ; Fri, 24 Apr 2020 15:22:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="TX9ORhic"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DJYepYnP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1035A206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 518FE843; Fri, 24 Apr 2020 17:22:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 518FE843 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587741777; bh=aLWv3eaknaTlsHMOsfr9P75/q0ksYi/EFOGMHSB+6Wg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TX9ORhicxHw7bmMsI5wV7hiAtQPfTliFHgNy3l1RJ2juFGM9N6TgYA752XT6ySoDV +uj4lJabn/oQDjPa/JCM30AsWUk8fpNpDaiBIPATFAER9kAErUktnRMPEml4iFbthQ 5LIplM/CprUMwzsCklfJPmF4K12nTT1zS5P56ZQU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AF501F80121; Fri, 24 Apr 2020 17:22:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 80828F80142; Fri, 24 Apr 2020 17:22:05 +0200 (CEST) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 79C15F80116 for ; Fri, 24 Apr 2020 17:22:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 79C15F80116 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DJYepYnP" Received: by mail-lj1-x241.google.com with SMTP id n6so10308252ljg.12 for ; Fri, 24 Apr 2020 08:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aLWv3eaknaTlsHMOsfr9P75/q0ksYi/EFOGMHSB+6Wg=; b=DJYepYnPRTIzVP9SKTevWcRZ+d5xf7ByvyA4Nl6uTjAz82fzkQ69VuNHCxoypstTER BFnNt0GXXeHzr4uERz/3Gg0sMapkNju8ROk1IEhjTgd3MHVbFUq4Cp5mB4g9Hv3zQV/7 k826z2TzRXXooo7kT4quu6hSmEYc1uuJUAx3xhD9v6odAGgLE1vxLbqpwARLeI+08WqX ZSqQeBfWLILrdlk1JF/MX8Qbo4+z3Aw18/HY+ZiltLmw4FdiY2NTGZQgtSma+suAoz2j G5HJ/WBlt6+GQ9vrs4iyiNESjSG9yFggv5EtYUABml0ZnFGmxYHNP+BOQvtF7vX5ojZf /YDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aLWv3eaknaTlsHMOsfr9P75/q0ksYi/EFOGMHSB+6Wg=; b=TW7Oyku2GnSd3iF3kgOR048p1jm/wjHhwuJyberMwQsu6iLnWtQtsD1teJBiNHpYR1 oSu9hwVs4Euo5VHC/bMAidbghAdxH/gQ+IxN55hGByGYAYJ8sMINoFwwDeNusvOw/elt yYsVj8R1l7zfOOPpgtOyjRLT9qx1hgq4IpSiYJOsKY0JIlWtn23FVsRwF+848IbrdT3l xRaOAVa3Pmlo6eGqfsuqOrXqMPCeoryMzkJBerEcl7xyzZ4zEWbumv8qJajHbFiDUjrE gn56tUpxN9Q3xKm40qxjZ5SpYDFkfJ4NIcFGCejF+jV6z8BZ+wKX4uSmpk7Ox+qoGLHT 2LtQ== X-Gm-Message-State: AGi0PubnyzCR/KuN4Mw8EHIURmFK0sNyYGxetQRWScQggTLyxHEOoksD oFhiUqZFeQMMBL0HSGjnrKKkXosDPafoHsC2LMJzWV4k2e9MbQ== X-Google-Smtp-Source: APiQypJn40GjeiS3BU3IkJfbeUl/ZwEOtPhT1mHus9Q0KlCF8g4AZvGpqFCNc9S2ETib0eAbO22LMmphp7k3bWvIH3w= X-Received: by 2002:a2e:b88b:: with SMTP id r11mr6250238ljp.116.1587741717593; Fri, 24 Apr 2020 08:21:57 -0700 (PDT) MIME-Version: 1.0 References: <20200424022449.14972-1-alexander@tsoy.me> <20200424022449.14972-2-alexander@tsoy.me> In-Reply-To: <20200424022449.14972-2-alexander@tsoy.me> From: Gregor Pintar Date: Fri, 24 Apr 2020 17:21:46 +0200 Message-ID: Subject: Re: [PATCH 2/2] ALSA: usb-audio: Remove async workaround for Scarlett 2nd gen To: Alexander Tsoy Content-Type: text/plain; charset="UTF-8" Cc: Takashi Iwai , alsa-devel@alsa-project.org, Roope Salmi X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Apr 24, 2020 at 4:24 AM Alexander Tsoy wrote: > > Frame size computation has been fixed and the workaround is no longer > needed. > It seems async is preferred and usually more reliable. Would it be possible to check, if there is feedback endpoint and use async, even if interface is reporting synchronous? Maybe make it configurable so it doesn't break devices with broken feedback endpoints.