Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Gregor Pintar <grpintar@gmail.com>
To: Alexander Tsoy <alexander@tsoy.me>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, Roope Salmi <rpsalmi@gmail.com>
Subject: Re: [PATCH 1/2] ALSA: usb-audio: Improve frames size computation
Date: Sat, 25 Apr 2020 20:09:58 +0200
Message-ID: <CAOPXC2ntasO-LfaozFGPi1Ux3vxF_oL1nSnQCwXTgpM6D1OM+w@mail.gmail.com> (raw)
In-Reply-To: <CAOPXC2nXJBp_qhOZwQALbB5ZQh4O-jPMVojCGUG-9tNH7-dQ3A@mail.gmail.com>

On Sat, Apr 25, 2020 at 6:50 PM Gregor Pintar <grpintar@gmail.com> wrote:
>
> On Fri, Apr 24, 2020 at 6:44 PM Alexander Tsoy <alexander@tsoy.me> wrote:
> >
> > В Пт, 24/04/2020 в 17:02 +0200, Gregor Pintar пишет:
> > > On Fri, Apr 24, 2020 at 4:24 AM Alexander Tsoy <alexander@tsoy.me>
> > > wrote:
> > > > This patch fixes this issue by implementing a different algorithm
> > > > for
> > > > frame size computation. It is based on accumulating of the
> > > > remainders
> > > > from division fs/fps and it doesn't accumulate errors over time.
> > > > This
> > > > new method is enabled for synchronous and adaptive playback
> > > > endpoints.
> > > >
> > >
> > > Hm, I still sometimes get click usually in about first 2 seconds,
> > > but it is hard to reproduce.
> >
> > I wonder if it's because the driver doesn't honor wLockDelay. Anyway,
> > the second patch can be reverted if there are still issues with 2nd gen
> > Scarletts.
> >
>
> I just got click with async. I better stop testing before I get click
> with 48kHz.
> Could this wLockDelay affect async too?
>
> Does anybody else still get clicks? I would totally think I'm mad, if
> I would not
> record them. Maybe it is something else.
>
> I guess I will just switch back to 48kHz and try not too think about it.

Guess what 48kHz sync and async clicks too.
It could be related to running capture at the same time.
It seems fine with 44.1kHz so far with input muted.

Sorry for all this spam.

      reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24  2:24 Alexander Tsoy
2020-04-24  2:24 ` [PATCH 2/2] ALSA: usb-audio: Remove async workaround for Scarlett 2nd gen Alexander Tsoy
2020-04-24  6:28   ` Takashi Iwai
2020-04-24 15:21   ` Gregor Pintar
2020-04-24  6:28 ` [PATCH 1/2] ALSA: usb-audio: Improve frames size computation Takashi Iwai
2020-04-24  9:19 ` Pavel Hofman
2020-04-24  9:29   ` Alexander Tsoy
2020-04-24  9:39     ` Pavel Hofman
2020-04-24 15:02 ` Gregor Pintar
2020-04-24 16:43   ` Alexander Tsoy
2020-04-25 16:50     ` Gregor Pintar
2020-04-25 18:09       ` Gregor Pintar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOPXC2ntasO-LfaozFGPi1Ux3vxF_oL1nSnQCwXTgpM6D1OM+w@mail.gmail.com \
    --to=grpintar@gmail.com \
    --cc=alexander@tsoy.me \
    --cc=alsa-devel@alsa-project.org \
    --cc=rpsalmi@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git