From: "Lu, Brent" <brent.lu@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Guennadi Liakhovetski" <guennadi.liakhovetski@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Mark Brown" <broonie@kernel.org>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Subject: RE: [PATCH] ASoC: hdac_hdmi: support 'ELD' mixer
Date: Tue, 18 Aug 2020 00:53:39 +0000 [thread overview]
Message-ID: <DM6PR11MB36421D93BA72DFCC14F899AD975C0@DM6PR11MB3642.namprd11.prod.outlook.com> (raw)
In-Reply-To: <s5hh7t3qbag.wl-tiwai@suse.de>
> > + /* add control for ELD Bytes */
> > + err = hdac_hdmi_create_eld_ctl(component, pcm);
> > + if (err < 0) {
> > + dev_err(&hdev->dev,
> > + "eld control add failed with err: %d for pcm: %d\n",
> > + err, device);
> > + kfree(pcm);
>
> pcm is allocated vida devm_kzalloc(), hence you shoudn't free it explicitly.
Will fix it in v2. Thanks.
Brent
>
>
> thanks,
>
> Takashi
next prev parent reply other threads:[~2020-08-18 0:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 8:34 [PATCH] ASoC: hdac_hdmi: support 'ELD' mixer Brent Lu
2020-08-16 7:50 ` Takashi Iwai
2020-08-18 0:53 ` Lu, Brent [this message]
2020-08-18 0:44 ` [PATCH v2] " Brent Lu
2020-08-18 11:45 ` Kai Vehmanen
2020-08-18 14:49 ` Lu, Brent
2020-08-18 14:36 ` [PATCH v3] " Brent Lu
2020-08-18 15:02 ` Mark Brown
2020-08-18 15:22 ` Lu, Brent
2020-08-18 17:10 ` Mark Brown
2020-08-18 16:54 ` Mark Brown
2020-08-18 17:39 ` Mark Brown
2020-08-18 16:55 ` [PATCH v2] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB36421D93BA72DFCC14F899AD975C0@DM6PR11MB3642.namprd11.prod.outlook.com \
--to=brent.lu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).