From: "Liao, Bard" <bard.liao@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: "pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"vinod.koul@linaro.org" <vinod.koul@linaro.org>,
"tiwai@suse.de" <tiwai@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ranjani.sridharan@linux.intel.com"
<ranjani.sridharan@linux.intel.com>,
"hui.wang@canonical.com" <hui.wang@canonical.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
"jank@cadence.com" <jank@cadence.com>,
"Kale, Sanyog R" <sanyog.r.kale@intel.com>,
"rander.wang@linux.intel.com" <rander.wang@linux.intel.com>
Subject: RE: [PATCH] regmap: sdw: add required header files
Date: Thu, 26 Nov 2020 10:37:18 +0000 [thread overview]
Message-ID: <DM6PR11MB40744C8625B57C4348989CE2FFF90@DM6PR11MB4074.namprd11.prod.outlook.com> (raw)
In-Reply-To: <X78+hlJTgA3FdmxY@kroah.com>
> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Thursday, November 26, 2020 1:35 PM
> To: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: alsa-devel@alsa-project.org; vkoul@kernel.org; vinod.koul@linaro.org;
> linux-kernel@vger.kernel.org; tiwai@suse.de; broonie@kernel.org;
> jank@cadence.com; srinivas.kandagatla@linaro.org;
> rander.wang@linux.intel.com; ranjani.sridharan@linux.intel.com;
> hui.wang@canonical.com; pierre-louis.bossart@linux.intel.com; Kale, Sanyog
> R <sanyog.r.kale@intel.com>; Liao, Bard <bard.liao@intel.com>
> Subject: Re: [PATCH] regmap: sdw: add required header files
>
> On Wed, Nov 25, 2020 at 09:01:28PM +0800, Bard Liao wrote:
> > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> >
> > Explicitly add header files used by regmap SoundWire support.
>
> What is failing to build without this?
I didn't see build errors. But, Documentation/process/submit-checklist.rst
says.
1) If you use a facility then #include the file that defines/declares
that facility. Don't depend on other header files pulling in ones
that you use.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2020-11-26 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 13:01 [PATCH] regmap: sdw: add required header files Bard Liao
2020-11-26 5:35 ` Greg KH
2020-11-26 10:37 ` Liao, Bard [this message]
2020-11-26 20:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB40744C8625B57C4348989CE2FFF90@DM6PR11MB4074.namprd11.prod.outlook.com \
--to=bard.liao@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).