From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41FEDC433E2 for ; Fri, 28 Aug 2020 01:48:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B821C20848 for ; Fri, 28 Aug 2020 01:48:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="BBGEqsGZ"; dkim=pass (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="HEOoN74n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B821C20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3C0D282E; Fri, 28 Aug 2020 03:48:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3C0D282E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598579335; bh=rBwpJD85gbD1nyTF8tmHqcy7VXEqJxfon6zI3JNdjps=; h=From:To:Subject:Date:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BBGEqsGZtCgRl+Ri7ivoiktCSJSNrh5VxNBzY4redRyOcDNkLLhuSeHDEvR3tJ6F7 7tZRkG4KWZMOM3doJ2AqMXfWjBaFr3D+xia4RNq7YbOmYhJCk6grkfiZnh/B1m4v4I MWm4xU10KP3RbF3P7qugVxKOi9vISnywS8LgBqmY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9D2ECF80143; Fri, 28 Aug 2020 03:48:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BB116F8016F; Fri, 28 Aug 2020 03:48:02 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3A4AFF800EB for ; Fri, 28 Aug 2020 03:47:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3A4AFF800EB Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="HEOoN74n" IronPort-SDR: D8qQkZJtbCUsM22Uk+9BX2jITrM819R9xn72bmIaY3GTv8S5NFu8bAIg8c5zE+0/gsutBEhGvl oHCbdbEUbteg== X-IronPort-AV: E=McAfee;i="6000,8403,9726"; a="157619097" X-IronPort-AV: E=Sophos;i="5.76,361,1592895600"; d="scan'208";a="157619097" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2020 18:47:23 -0700 IronPort-SDR: VYCSw9dqJQd0W/QvpW4Mo+y/0VzFQK9PkUJG8MusNTPtunCU6kToz9LAFPx6U/qg4NkV/IRZyc aVLB8WJO+1JA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,361,1592895600"; d="scan'208";a="332392179" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 27 Aug 2020 18:47:22 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 27 Aug 2020 18:47:17 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 27 Aug 2020 18:47:17 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Aug 2020 18:47:17 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.48) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Aug 2020 18:47:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LXneScp7a1fof8rS/23y4zz8Y1menTNPAgho/j9gYPT2zojknLtU1Sdrt7RA73Qyn6pMl70kjTEJE8dw7oMmpd2vqcDlb7J37MFDGVd2Il3zfeJ/B+JdHqdLIU6rRoSDumzDuXaIpv8tyteYnIGXwdzz9vj4UgS4TWZ13sernH9ciBox42Y3Gaj773FVOMSg3JERA7zQvSchGBLR8AHhmdYjzWxlhvrcGObgd4KhLy6poeK5jcZHeXZYZ4eNEezlFMQGBys4ZEq48HKTiJDLGUobRoAD5TbhwLAWzSUPqxqGMNMfGUowoTATyjVNipmAaCzaNPfAnSi7+Bn9/pZX7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a58rFFQ9cD77hFtgEYaW4+ObA3XRqFfAwquv5WtvHP0=; b=QvGNsf/4h+GTYYgQ6JYF9t0ERrWwjA/i/d2t4oLM1k/FvZCO/us/+qizdDLgJdBAi9hRTTCNnP/wSmb3x7pFGgUMWqT+bK2xGa43ZzhYNVtXKWXlVXgSx0NXLFY20m+EZ7PJTpf4c+wHwcRrvtl2pOUmxcVMgiwTQVbIscGllxkYKwaaX5dW5D8GZzXeL9jpnQ0D7Kk+JNpcDqvUqH/o5n3Y024C9epxUPzgk7aHxWXdrVic2vpKA403Lsf6hCX0sYP8mgsYIj5YYG4ze+UuwnKr8/UbvPuAxLyAUySxyGUvAPn5V7uToSp71L2fo2XdktzK93y5CkBzzSD7bvy3OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a58rFFQ9cD77hFtgEYaW4+ObA3XRqFfAwquv5WtvHP0=; b=HEOoN74nSRdE1Be8kkr59npw8XeSJqN/P/yL776E1Pz6/FUb9PT47xBdlyZCtPutgP+bSL9oHvYFx/dvpM0vLylpeXOfS58ICrzLh33XhdE9DqzRaDky7qWVhKAKFG6KF1aSxLLTKu7rgubAbgFHYs01z6m/McXwuaY7a6OKmdY= Received: from DM6PR11MB4074.namprd11.prod.outlook.com (2603:10b6:5:5::11) by DM5PR11MB1787.namprd11.prod.outlook.com (2603:10b6:3:112::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24; Fri, 28 Aug 2020 01:47:15 +0000 Received: from DM6PR11MB4074.namprd11.prod.outlook.com ([fe80::a061:bd5e:c46a:fa40]) by DM6PR11MB4074.namprd11.prod.outlook.com ([fe80::a061:bd5e:c46a:fa40%3]) with mapi id 15.20.3305.032; Fri, 28 Aug 2020 01:47:15 +0000 From: "Liao, Bard" To: Vinod Koul , Bard Liao Subject: RE: [PATCH 07/11] soundwire: intel: Only call sdw stream APIs for the first cpu_dai Thread-Topic: [PATCH 07/11] soundwire: intel: Only call sdw stream APIs for the first cpu_dai Thread-Index: AQHWdWzjed4H7siPVEC/M4NN62YhKalKMLkAgAKcpAA= Date: Fri, 28 Aug 2020 01:47:14 +0000 Message-ID: References: <20200818024120.20721-1-yung-chuan.liao@linux.intel.com> <20200818024120.20721-8-yung-chuan.liao@linux.intel.com> <20200826094636.GB2639@vkoul-mobl> In-Reply-To: <20200826094636.GB2639@vkoul-mobl> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [220.133.4.96] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc3de138-b36c-45c5-eb23-08d84af44a3a x-ms-traffictypediagnostic: DM5PR11MB1787: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YzvWGBQg5R326JeGIhv9bpeD2fBuNNzDabfm/elgEhsOq85J/OGj9Y5fnXty1g1xIE2RlF6fCg8x8ONk8qDU3lP95vo6fw9RhbIUtC6MSNm0BaYke7B5GaH90ygkEu0davxMDMNi3X2dl1A/VHf1VAvQewHNQsE0Z2enKNqskNleiZ4WhOooRL26WZJywQVkt/YTNf7pNM78KepKczbcmDe3AVtJ7GqEmIuv6rjv+dXzrSBcE54AW6T37dhtibhK6BaOnmzzJImOk9kMOopcOp3cIJosOYTr8u2NzAYARy1/9xidgk3j36lpuFFiYw6vSjHoCK7CSqummaXqkZYd3g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4074.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(39860400002)(396003)(346002)(53546011)(8676002)(6506007)(110136005)(7696005)(316002)(478600001)(54906003)(55016002)(52536014)(9686003)(5660300002)(8936002)(2906002)(7416002)(71200400001)(66946007)(186003)(33656002)(4326008)(26005)(86362001)(83380400001)(76116006)(64756008)(66476007)(66556008)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: z9aaQikUMUHwOoW059L8avh/Cp7CeLXstl5OueEo1nuNaxeXLmba52Ug9RMdtti5apatM2KbbbIhxyLozQT1FjGpf3ApdF+7rNECqaNIVP5WtR2VB1wPywLiVszT8x99JHYU2RZGNguLRb5+B/xTwSYi9+ayV3zUpkIP18wy5ab4Ip5qTwKYzuRz1o75+fimDrBM7WSgyP69z5fS6N4aCmUrvjLUqMYtOo85UIZEjeP0FTINEy83F0B9G5fDCJkpkYo/QNIqWltcDcdTsrz9AgFsQDk4PzI2UBRZyACYS+FWatPP2mGDfwlaRuOjHiOlxsnCWiMyAI2D2jzwZbdxWv/h4xdLDoyZ6WlFgg95PtrKTZuds8tb87QuVP/sTfsxprAtHGrL6dKsGs7sDVQAKV1S5ltmWnd5cq8YP3IGPqDZcrX9gI4mHseyQKyJpjJCrloaLRSUeu7tM5vCM0+X6gQsyWOmqo/WZ0fJazCY6lSRzIx6Ouw0JInJcsYWQKx/dMxYpvY3Y9WFPQeH8FVZ+mo9RcPck9OPQI5X9gL2WRqOBDcFjrxW5fN3ovN7jEQe9jCcCYzF+KwmO3Gafwz6sXtvmShLPoo6Ms+clc8WaZJk4Um0/Lo6/zdkftJYraCAvDzPO5kKbnvusDSjjg97ZQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4074.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc3de138-b36c-45c5-eb23-08d84af44a3a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2020 01:47:14.9406 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fUcCTMgnXmj6qXhuXPbSRvU9+R5i0A/JliW5CT2zDRgB7aYU6R5KIueTU0LhK5qpufh1EGkowNYKUsiZR1brmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1787 X-OriginatorOrg: intel.com Cc: "pierre-louis.bossart@linux.intel.com" , "alsa-devel@alsa-project.org" , "tiwai@suse.de" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "ranjani.sridharan@linux.intel.com" , "hui.wang@canonical.com" , "broonie@kernel.org" , "srinivas.kandagatla@linaro.org" , "jank@cadence.com" , "Lin, Mengdong" , "Kale, Sanyog R" , "rander.wang@linux.intel.com" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > -----Original Message----- > From: Vinod Koul > Sent: Wednesday, August 26, 2020 5:47 PM > To: Bard Liao > Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; tiwai@suse= .de; > broonie@kernel.org; gregkh@linuxfoundation.org; jank@cadence.com; > srinivas.kandagatla@linaro.org; rander.wang@linux.intel.com; > ranjani.sridharan@linux.intel.com; hui.wang@canonical.com; pierre- > louis.bossart@linux.intel.com; Kale, Sanyog R ; = Lin, > Mengdong ; Liao, Bard > Subject: Re: [PATCH 07/11] soundwire: intel: Only call sdw stream APIs fo= r > the first cpu_dai >=20 > On 18-08-20, 10:41, Bard Liao wrote: > > We should call these APIs once per stream. So we can only call it when > > the dai ops is invoked for the first cpu dai. > > > > Signed-off-by: Bard Liao > > Reviewed-by: Pierre-Louis Bossart > > > > Reviewed-by: Ranjani Sridharan > > --- > > drivers/soundwire/intel.c | 45 > > +++++++++++++++++++++++++++++++++------ > > 1 file changed, 39 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > > index 89a8ad1f80e8..7c63581270fd 100644 > > --- a/drivers/soundwire/intel.c > > +++ b/drivers/soundwire/intel.c > > @@ -941,11 +941,13 @@ static int intel_hw_params(struct > > snd_pcm_substream *substream, static int intel_prepare(struct > snd_pcm_substream *substream, > > struct snd_soc_dai *dai) > > { > > + struct snd_soc_pcm_runtime *rtd =3D substream->private_data; > > + struct snd_soc_dai *first_cpu_dai =3D asoc_rtd_to_cpu(rtd, 0); > > struct sdw_cdns *cdns =3D snd_soc_dai_get_drvdata(dai); > > struct sdw_intel *sdw =3D cdns_to_intel(cdns); > > struct sdw_cdns_dma_data *dma; > > int ch, dir; > > - int ret; > > + int ret =3D 0; > > > > dma =3D snd_soc_dai_get_dma_data(dai, substream); > > if (!dma) { > > @@ -985,7 +987,13 @@ static int intel_prepare(struct > snd_pcm_substream *substream, > > goto err; > > } > > > > - ret =3D sdw_prepare_stream(dma->stream); > > + /* > > + * All cpu dais belong to a stream. To ensure sdw_prepare_stream > > + * is called once per stream, we should call it only when > > + * dai =3D first_cpu_dai. > > + */ > > + if (first_cpu_dai =3D=3D dai) > > + ret =3D sdw_prepare_stream(dma->stream); >=20 > Hmmm why not use the one place which is unique in the card to call this, > hint machine dais are only called once. Yes, we can call it in machine driver. But, shouldn't it belong to platform level? The point is that if we move the stuff to machine driver, it will force people to implement these stuff on their own Intel machine driver. >=20 > ~Vinod