From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5F4C4363A for ; Fri, 23 Oct 2020 12:07:00 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2015E208E4 for ; Fri, 23 Oct 2020 12:06:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="KvwhR1Yl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2015E208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7EDA217FD; Fri, 23 Oct 2020 14:06:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7EDA217FD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1603454815; bh=4cAo30qnQTv3GRrV0tupSdn/lOjecfre/ES4gVPpE68=; h=Date:From:Subject:To:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KvwhR1Yl0uh5Xe99613+a1jvNUZl/ruyX4T98LufI8uQd6VGDknKF3Fyi4ISdRBTD wa2wfsX4FR5yglVbf/gyRWk4HnK/N3LkGrWRxu/wgpDCzHhEvi/7ScGTTV7/P4TYqA JIeSkWy2YWt7AMQBxt7fX2Cu74D/EAB4WdEos6Ho= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C6F83F80253; Fri, 23 Oct 2020 14:06:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6F206F8025A; Fri, 23 Oct 2020 14:06:02 +0200 (CEST) Received: from aposti.net (aposti.net [89.234.176.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3F59DF80247 for ; Fri, 23 Oct 2020 14:05:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3F59DF80247 Date: Fri, 23 Oct 2020 13:05:20 +0100 From: Paul Cercueil Subject: Re: [PATCH] ASoC: jz4740-i2s: Remove manual DMA peripheral ID assignment To: Lars-Peter Clausen Message-Id: In-Reply-To: <20201023092346.5777-1-lars@metafoo.de> References: <20201023092346.5777-1-lars@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Cc: alsa-devel@alsa-project.org, Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Le ven. 23 oct. 2020 =E0 11:23, Lars-Peter Clausen a=20 =E9crit : > All platforms that use the jz4740-i2s driver have been switched to > devicetree for a while now and the assignment of the DMA peripheral ID > is done in the devicetree. >=20 > It is no longer necessary to manually assign the peripheral ID in the > driver, so remove that. The DMA driver does not even look at the value > assigned in the driver anymore and always uses the value provided by=20 > the > devicetree. >=20 > Signed-off-by: Lars-Peter Clausen Reviewed-by: Paul Cercueil Cheers, -Paul > --- > sound/soc/jz4740/jz4740-i2s.c | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/sound/soc/jz4740/jz4740-i2s.c=20 > b/sound/soc/jz4740/jz4740-i2s.c > index c7bd20104b20..e8bc7ca5ee5e 100644 > --- a/sound/soc/jz4740/jz4740-i2s.c > +++ b/sound/soc/jz4740/jz4740-i2s.c > @@ -26,9 +26,6 @@ >=20 > #include "jz4740-i2s.h" >=20 > -#define JZ4740_DMA_TYPE_AIC_TRANSMIT 24 > -#define JZ4740_DMA_TYPE_AIC_RECEIVE 25 > - > #define JZ_REG_AIC_CONF 0x00 > #define JZ_REG_AIC_CTRL 0x04 > #define JZ_REG_AIC_I2S_FMT 0x10 > @@ -377,13 +374,11 @@ static void jz4740_i2c_init_pcm_config(struct=20 > jz4740_i2s *i2s) > /* Playback */ > dma_data =3D &i2s->playback_dma_data; > dma_data->maxburst =3D 16; > - dma_data->slave_id =3D JZ4740_DMA_TYPE_AIC_TRANSMIT; > dma_data->addr =3D i2s->phys_base + JZ_REG_AIC_FIFO; >=20 > /* Capture */ > dma_data =3D &i2s->capture_dma_data; > dma_data->maxburst =3D 16; > - dma_data->slave_id =3D JZ4740_DMA_TYPE_AIC_RECEIVE; > dma_data->addr =3D i2s->phys_base + JZ_REG_AIC_FIFO; > } >=20 > -- > 2.20.1 >=20