From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com,
Shumin Chen <chenshumin86@sina.com>
Subject: Re: [PATCH 1/2] ASoC: add ES8156 codec driver
Date: Fri, 10 Dec 2021 16:29:07 +0000 [thread overview]
Message-ID: <YbOAUxygSKNUqRZG@sirena.org.uk> (raw)
In-Reply-To: <42b70959-3bfb-7370-4ea4-39833b6e42d9@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]
On Fri, Dec 10, 2021 at 09:53:39AM -0600, Pierre-Louis Bossart wrote:
> On 12/10/21 9:10 AM, Shumin Chen wrote:
> > +static int es8156_resume(struct snd_soc_component *codec)
> > +{
> > + return 0;
> es8156_set_bias_level(codec, SND_SOC_BIAS_ON);
> for symmetry with suspend?
Shouldn't be _ON since we're resuming so there should be no running
audio - _STANDBY would be more normal.
> > +static int es8156_probe(struct snd_soc_component *codec)
> > +{
> > + struct es8156_priv *es8156 = snd_soc_component_get_drvdata(codec);
> > + int ret = 0;
> > +
> > + es8156_codec = codec;
> > +
> > +#if MCLK
> > + es8156->mclk = devm_clk_get(codec->dev, "mclk");
> > + if (PTR_ERR(es8156->mclk) == -EPROBE_DEFER)
> > + return -EPROBE_DEFER;
> > + ret = clk_prepare_enable(es8156->mclk);
> > +#endif
> Unclear how MCLK will be enabled in a build, did you mean
> es8156->mclk = devm_clk_get_optional(codec->dev, "mclk");
Please also move all resource acquisition to the I2C level probe, that
means we don't get the card trying to instantiate repeatedly while the
CODEC isn't ready.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-12-10 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 15:10 [PATCH 0/2] This patches provide ASoc codec support for ES8156 Shumin Chen
2021-12-10 15:10 ` [PATCH 1/2] ASoC: add ES8156 codec driver Shumin Chen
2021-12-10 15:53 ` Pierre-Louis Bossart
2021-12-10 16:29 ` Mark Brown [this message]
2021-12-10 17:32 ` kernel test robot
2021-12-10 15:10 ` [PATCH 2/2] ASoC: convert Everest ES8156 binding to yaml Shumin Chen
2021-12-10 16:29 ` Pierre-Louis Bossart
2021-12-10 16:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbOAUxygSKNUqRZG@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=chenshumin86@sina.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).