From: Mark Brown <broonie@kernel.org>
To: Dylan Van Assche <me@dylanvanassche.be>
Cc: Banajit Goswami <bgoswami@quicinc.com>,
Takashi Iwai <tiwai@suse.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Joel Selvaraj <joelselvaraj.oss@gmail.com>,
Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH v3 1/1] sound: soc: codecs: wcd-mbhc-v2: expose ALSA control for jack
Date: Sat, 25 Mar 2023 18:12:23 +0000 [thread overview]
Message-ID: <ZB85h55to1MsQnnh@sirena.org.uk> (raw)
In-Reply-To: <20230325142142.24337-2-me@dylanvanassche.be>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
On Sat, Mar 25, 2023 at 03:21:42PM +0100, Dylan Van Assche wrote:
>
> mutex_lock(&mbhc->lock);
>
> + ret = snd_jack_add_new_kctl(mbhc->jack->jack, "Headset Jack", WCD_MBHC_JACK_MASK);
> + if (ret)
> + dev_warn(component->dev, "failed creating Headset Jack kctl with err: %d\n", ret);
> +
No, drivers should not be open coding userspace reporting - there
is no reason for this device to be special, or for this device to
duplicate what machine drivers and the core are doing. Any
configuration should be done by the machine driver, the ASoC core
jack handling already creates userspace controls when asked.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-03-25 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230325142142.24337-1-me@dylanvanassche.be>
2023-03-25 14:21 ` [PATCH v3 1/1] sound: soc: codecs: wcd-mbhc-v2: expose ALSA control for jack Dylan Van Assche via Alsa-devel
2023-03-25 18:02 ` [PATCH v3 0/1] Expose " Mark Brown
[not found] ` <20230325142142.24337-2-me@dylanvanassche.be>
2023-03-25 18:12 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB85h55to1MsQnnh@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=caleb@connolly.tech \
--cc=joelselvaraj.oss@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@dylanvanassche.be \
--cc=phone-devel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).