From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ADA2C6FD1C for ; Wed, 22 Mar 2023 21:37:14 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CB766EA0; Wed, 22 Mar 2023 22:36:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CB766EA0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1679521032; bh=O5urGvWE65epCWTJLDmjCHr4A+CyLtsq+Kqk9qfHOL4=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=IJgA17vnVe8Z1qi/wIse6I9prVOVTXjguCRWTW194H1nei/YmZhCn8Kx6Vyd+yJ7/ 0NjyWXRfWJ1AwPhRydPoZlqVjfDKRmouIm9/05yzhA/NN4T2FBEvhP6B33xTn03WF2 NtpT8WlyALAylGI34UStKcss6WXHzGZC1PxpmLpM= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 88461F802E8; Wed, 22 Mar 2023 22:36:00 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CEC18F8027B; Wed, 22 Mar 2023 22:35:57 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 002DDF8024E for ; Wed, 22 Mar 2023 22:35:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 002DDF8024E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SnaWKepN Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B4F90622E9; Wed, 22 Mar 2023 21:35:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9F21C433EF; Wed, 22 Mar 2023 21:35:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679520951; bh=O5urGvWE65epCWTJLDmjCHr4A+CyLtsq+Kqk9qfHOL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SnaWKepNaCqaM0TGWvWnmgG9ZOTs1u+Sgl9iE1yv6p16x9G2frQ2/P6nEhG0XWMRh ftOlbraFA/yRMLAqneu0snlMCiotob4hI6Mj29q7Qq3Z4+0t1axSmrOTafJibksJzW 5CAw/4Jhdd6hZw8khDaiQIDpHukFoWgrTrfMmybEHIrvCZlgWldQoJSjAjpbEP2Rvw naM96uSXJuGSi050+lsZKAFNKcdT3x8N80/NPRS4CvhfxLCYHOl2S6o1eCWjvxmwDk su+uB2tUF2VFcbdUooT7C/XfsUWiNJ1oEf9kqsaeRFRvphbWGR7KZsUeSmX6bJPXjZ rkQ2k7jy9WYkA== Date: Wed, 22 Mar 2023 21:35:47 +0000 From: Mark Brown To: Marian Postevca Subject: Re: [PATCH 4/4] ASoC: amd: acp: Improve support for speaker power events Message-ID: References: <20230320203519.20137-1-posteuca@mutex.one> <20230320203519.20137-5-posteuca@mutex.one> <0989fc51-fee7-4558-ba2c-084cc4fb6833@sirena.org.uk> <87r0tgjy9v.fsf@mutex.one> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wNnmN3SGdiALnLaa" Content-Disposition: inline In-Reply-To: <87r0tgjy9v.fsf@mutex.one> X-Cookie: Single tasking: Just Say No. Message-ID-Hash: 4KG54NZBGZZ2YGBAUUFR6M5ZIE2QMTFI X-Message-ID-Hash: 4KG54NZBGZZ2YGBAUUFR6M5ZIE2QMTFI X-MailFrom: broonie@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Takashi Iwai , Liam Girdwood , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --wNnmN3SGdiALnLaa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 22, 2023 at 11:01:48PM +0200, Marian Postevca wrote: > Mark Brown writes: > > The usual mechanism for doing this is with the standard kernel delay > > functions. Why not use them in the DAPM event? > I just followed the logic from sof_es8336.c, the reason for the change > there is given in commit log of 89cdb224f2abe37ec: > commit 89cdb224f2abe37ec4ac21ba0d9ddeb5a6a9cf68 > Author: Zhu Ning > Date: Fri Oct 28 10:04:56 2022 +0800 > ASoC: sof_es8336: reduce pop noise on speaker > The Speaker GPIO needs to be turned on slightly behind the codec turned on. > It also need to be turned off slightly before the codec turned down. > Current code uses delay in DAPM_EVENT to do it but the mdelay delays the > DAPM itself and thus has no effect. A delayed_work is added to turn on the > speaker. > The Speaker is turned off in .trigger since trigger is called slightly > before the DAPM events. This just sounds like a complicated way of implementing a DAPM POST event? Or now I think about it possibly we just need to tweak the current sorting such that speakers aren't run in parallel with headphones and line outputs, that should cover any issues with external speaker amplifiers. AFAICT the issue here is a speaker driver amplifying a pop in a line output from the CODEC? --wNnmN3SGdiALnLaa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQbdLIACgkQJNaLcl1U h9AUnwf+OVcj15mqwDAb7rmH2vJ7jbUAEpSCQ1QLsxCiVu+GmGNG8AGELD60P7W4 rN7oAGSHPfKOFKBf9igvag/7DruYk6nhhB4yCI6DwQ/XYiJKqH8NT7MnPKf3r+WI XcUS4il+ynF0zQx5OinVjmqhjOZN4aJxij62DdsZsaaR1nXeoG8miJwp4XN6BTzo is7MtVHoU78ZfIe+JtY+U9aJZirsL5e2S8uzxYckSt5SZWNWThnklIEWW2Cq84Ll gK1qM7UimxsAwSucT7/EfKIk31CxKkfJllhADldZNwIiwVg5LlYmjIc3Gx/BnkYS BNVGgblEi2Ofos8t6iYuD7lI+6/b/w== =OYG4 -----END PGP SIGNATURE----- --wNnmN3SGdiALnLaa--