From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7A69C432C0 for ; Thu, 21 Nov 2019 15:43:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52F16206B6 for ; Thu, 21 Nov 2019 15:43:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="kfe1DjuF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52F16206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9BB631784; Thu, 21 Nov 2019 16:42:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9BB631784 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1574351014; bh=+s2iO9e8lvLHT9afpXzoeUJ7L9Zgra2M6AeAS7fCj5Q=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kfe1DjuFe9CWwJK6M0PSP2gnpwar+5CepC2e8KSIMPGjH7VYdxMTevfNz8zw/RIaf KXlaHoq71wtQlMGrULn6nc5pInihbPsE1PgYscZVOt3+OR0G76oW05cEU705WedbtG tjXycguCeBA+M6iaAKac+3jP598ppZWEK01ieDws= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B69ECF8015E; Thu, 21 Nov 2019 16:41:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6669BF80146; Thu, 21 Nov 2019 16:41:42 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 41F2CF80146 for ; Thu, 21 Nov 2019 16:41:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 41F2CF80146 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 07:41:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,226,1571727600"; d="scan'208";a="205105013" Received: from ptan2-mobl1.amr.corp.intel.com (HELO [10.255.231.235]) ([10.255.231.235]) by fmsmga008.fm.intel.com with ESMTP; 21 Nov 2019 07:41:33 -0800 To: Mark Brown , Jaroslav Kysela References: <20191120174435.30920-1-perex@perex.cz> <20191121115124.GA4071@sirena.org.uk> <7a527497-6132-c1df-d083-6cd27361eb08@perex.cz> <20191121121136.GB4071@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: Date: Thu, 21 Nov 2019 09:14:15 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191121121136.GB4071@sirena.org.uk> Content-Language: en-US Cc: Takashi Iwai , ALSA development Subject: Re: [alsa-devel] [PATCH v2 1/2] ASoC: improve the DMI long card code in asoc-core X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 11/21/19 6:11 AM, Mark Brown wrote: > On Thu, Nov 21, 2019 at 01:02:38PM +0100, Jaroslav Kysela wrote: >> Dne 21. 11. 19 v 12:51 Mark Brown napsal(a): >>> On Wed, Nov 20, 2019 at 06:44:34PM +0100, Jaroslav Kysela wrote: > >>>> - /* make up dmi long name as: vendor.product.version.board */ >>>> + /* make up dmi long name as: vendor-product-version-board */ > >>> I'm worried about this from an ABI point of view with people's UCM >>> files. But perhaps I'm worrying about nothing? > >> this is just the C comment fix. The long name is already in >> vendor-product-version-board - no dots as delimiters (but does are allowed >> in the fields like version strings). This code improvement does not change >> the format of the generated long name string from the DMI information. > > Ah, it looked from my initial scan like it was being changed as a result > of the factoring out of the append code. I had the same reaction on v1, it's just cleaning up a bad comment indeed. This looks good to me, especially the removal of redundant parts, so for the patch 1..2 Reviewed-by: Pierre-Louis Bossart _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel