From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FC8C11D05 for ; Thu, 20 Feb 2020 14:16:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D760C208E4 for ; Thu, 20 Feb 2020 14:16:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="qCBjlnhX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pCKRt1az" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D760C208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2CD9316AC; Thu, 20 Feb 2020 15:15:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2CD9316AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582208175; bh=nhkO0L5W/TIBgnWQYh2CE0bwGDpvvqVbP+REfIkcux0=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qCBjlnhXBK0PR4ZpX2XjB5GC5okR4/n5EleghwJ3QR8OSn4KDTjvuukW7TgPIS1E9 XZwJibFSGwg9K4PXDPxlGz/qiF8b4I8U2jZW/Zs/vgMWY4X2qDe36EA310dY6JCs8G w1LhuRTH0wf+ntj22TQsxaMn6GWU5aBuVPWYYy8E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 984E3F80145; Thu, 20 Feb 2020 15:15:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BC6FDF80148; Thu, 20 Feb 2020 15:15:22 +0100 (CET) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CCFEDF80101 for ; Thu, 20 Feb 2020 15:15:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CCFEDF80101 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pCKRt1az" Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 01KEFGMm051288; Thu, 20 Feb 2020 08:15:16 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1582208116; bh=Axzg4rCh+ok1KaDsGcP9AyakqPBpC/mwibitdg3IGVw=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=pCKRt1az0CeDDzXENnEc0MpcujZQB0YGekohRP4P5jXgjcreBXflff1LrL4Ub1TZL DxnB5RImn2+G2ZNRAVYSsuCfZIUK4AoioyfGKQNj8G3Qufr3OerZ/OA32JqhUfiHat rpVl02uBPoe3igOGt4IAxogn0D0GewhssAGRTp5A= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 01KEFGMQ012068 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 20 Feb 2020 08:15:16 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 20 Feb 2020 08:15:16 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 20 Feb 2020 08:15:16 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 01KEFCgO095562; Thu, 20 Feb 2020 08:15:12 -0600 Subject: Re: [PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card To: Sebastian Reichel References: <20200211171645.41990-1-tony@atomide.com> <20200212143543.GI64767@atomide.com> <346dfd2b-23f8-87e0-6f45-27a5099b1066@ti.com> <20200214170322.GZ64767@atomide.com> <20200217231001.GC35972@atomide.com> <5402eba8-4f84-0973-e11b-6ab2667ada85@ti.com> <20200218211631.fxojsxzvttoidfed@earth.universe> From: Peter Ujfalusi Message-ID: Date: Thu, 20 Feb 2020 16:15:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200218211631.fxojsxzvttoidfed@earth.universe> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, Kuninori Morimoto , Aaro Koskinen , Tony Lindgren , linux-kernel@vger.kernel.org, Merlijn Wajer , Takashi Iwai , Liam Girdwood , Mark Brown , Pavel Machek , "Arthur D ." , Jarkko Nikula X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Sebastian, On 18/02/2020 23.16, Sebastian Reichel wrote: >> The simplest use cases you want to support: >> A. McBSP3 <-> CPCAP_voice (playback/capture) >> B. MDM6600 <-> CPCAP_voice (handset mic/speaker voice call) >> C. MDM6600 <-> WL1285 (BT voice call) >> D. McBSP3 <-> BT (VoIP?) > > Your description matches my understanding of the hardware setup. > >> I would not bother with recording the call as you would need tom >> reconfigure the McBSP playback pin (is it even possible) as input to >> OMAP4, I think.. >> >> B/C is codec2codec, McBSP3 is not involved at all. >> A/D is when McBSP3 is used only. >> >> Imho this can be represented as >> McBSP2: 1 port >> 1.1: to CPCAP_hifi >> >> McBSP3: 1 port, 2 endpoint >> 2.1: to CPCAP_voice >> 2.2: to WL1285 >> CPCAP: 2 ports >> hifi: 3.1: to McBSP2 >> voice: 4.1: to McBSP3 >> 4.2: to MDM6600 >> MDM6600: 2 ports > > I suppose you mean 1 port, 2 endpoints? Oh yes. Numbers.... > >> 5.1: to CPAC_voice >> 5.2: to WL1285 >> WL1285: 2 ports > > and here too? here too ;) > >> 6.1: to McBSP3 >> 6.2: to MDM6600 >> >> The machine driver should switch between the graph links based on the >> use case for the interconnected devices: >> A: 2.2 <-> 4.1 >> B: 4.2 <-> 5.1 >> C: 6.2 <-> 5.1 >> D: 2.2 <-> 6.1 >> >> Can a generic card provide such a functionality? > > I suppose in the end its a question if generic card can provide TDM > support. Sure it can, but can it handle the switching between the paths based on use cases? There should be machine level DAPM widgets to kick codec2codec (MDM6600 - CPAC_voice for example) and also to make sure that when you switch between them the system is not going to get misconfigured. Switching between CPAC and BT route during call? Not allowing VoIP while on call, etc. >> In case of B/C you should not have a running stream imho. > > I would expect, that MDM6600 codec marks itself as running/stopped > based on call state. That should enable DAPM widgets automatically > when CPCAP_voice is routed to MDM6600? > >> In all cases CPCAP_voice should be able to run the clocks on i2s, >> even if it is not used by the audio setup. >> Not sure if you can just turn Wl1285 as master, but it is possible >> that it is master, but silent when it is not used? > > I provided CPCAP registers for BT call, which should be enough to > figure this out (I did not yet analyze the results myself). I got the datasheet from NXP (thanks for the pointer!), I try to look at it in a coming days. >> I'm not sure if we should span out dummy dais for endpoints within a >> port. Imho the port _is_ the dai. Different endpoints might use >> different TDM slots on the port (or the same slot, which makes them >> exclusive). > > Makes sense to me. > > -- Sebastian - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki