From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>,
moderated for non-subscribers <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH] ASoC: qcom: MSM8996 depends on COMMON_CLK
Date: Fri, 30 Oct 2020 11:31:25 -0700 [thread overview]
Message-ID: <a55d71fd-d5b1-26f9-c3f0-7f2ff91bef07@infradead.org> (raw)
In-Reply-To: <548bb7f8-672d-3d95-0d78-cef1c9837a42@infradead.org>
On 10/16/20 10:39 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix a kconfig warning in sound/soc/qcom:
>
> WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n]
> Selected by [y]:
> - SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y]
>
> This is needed because 'select' does not follow dependency chains.
>
> Fixes: a6f933f63f2f ("ASoC: qcom: apq8096: Add db820c machine driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: alsa-devel@alsa-project.org
> ---
> Found in linux-next but applies to mainline.
>
> sound/soc/qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20201016.orig/sound/soc/qcom/Kconfig
> +++ linux-next-20201016/sound/soc/qcom/Kconfig
> @@ -106,6 +106,7 @@ config SND_SOC_QDSP6
> config SND_SOC_MSM8996
> tristate "SoC Machine driver for MSM8996 and APQ8096 boards"
> depends on QCOM_APR
> + depends on COMMON_CLK
> select SND_SOC_QDSP6
> select SND_SOC_QCOM_COMMON
> help
>
Ping. I am still seeing this kconfig warning in linux-next 20201030.
--
~Randy
next prev parent reply other threads:[~2020-10-30 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 17:39 [PATCH] ASoC: qcom: MSM8996 depends on COMMON_CLK Randy Dunlap
2020-10-30 18:31 ` Randy Dunlap [this message]
2020-10-30 18:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a55d71fd-d5b1-26f9-c3f0-7f2ff91bef07@infradead.org \
--to=rdunlap@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).