From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Takashi Iwai <tiwai@suse.de>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [alsa-devel] [PATCH 0/2] ASoC: fixup topology dai_link remove issue
Date: Tue, 19 Nov 2019 07:37:09 -0600 [thread overview]
Message-ID: <a63127e6-fbf1-af5e-d4f5-5b98c00040b5@linux.intel.com> (raw)
In-Reply-To: <87y2wc6584.wl-kuninori.morimoto.gx@renesas.com>
On 11/18/19 7:10 PM, Kuninori Morimoto wrote:
>
> Hi Pierre-Louis
>
>>> These are already tested by Intel CI, and all issues were solved.
>>> (https://github.com/thesofproject/linux/pull/1504)
>>> Extra Tested-by / Reviewed-by are very welcome from Intel
>>
>> if you don't mind I'd like to retest this new series, it's based on a
>> different tip and is not exactly the same as before.
>
> Yes, of course.
> Sorry I didn't mention about it.
>
>> - /* free the ALSA card at first; this syncs with pending operations */
>> - if (card->snd_card) {
>> - snd_card_free(card->snd_card);
>> - card->snd_card = NULL;
>> - }
>> + if (card->snd_card)
>> + snd_card_disconnect_sync(card->snd_card);
>>
>> snd_soc_dapm_shutdown(card); <<< not tested yet.
>>
>> /* remove and free each DAI */
>> soc_remove_link_dais(card);
>> + soc_remove_link_components(card);
>
> Yes.
> It is from
>
> 2a6f0892bda954dc2688b002060093ee0fe38528
> ("ASoC: soc-core: call snd_soc_dapm_shutdown() at soc_cleanup_card_resources()")
No regression detected so from the Intel side we're good with this patchset.
Thanks Morimoto-san for this comprehensive analysis, really nice work!
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-19 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 1:49 [alsa-devel] [PATCH 0/2] ASoC: fixup topology dai_link remove issue Kuninori Morimoto
2019-11-18 1:50 ` [alsa-devel] [PATCH 1/2] ASoC: soc-component: tidyup snd_soc_pcm_component_new/free() parameter Kuninori Morimoto
2019-11-20 17:18 ` [alsa-devel] Applied "ASoC: soc-component: tidyup snd_soc_pcm_component_new/free() parameter" to the asoc tree Mark Brown
2019-11-18 1:51 ` [alsa-devel] [PATCH 2/2] ASoC: soc-pcm: remove soc_pcm_private_free() Kuninori Morimoto
2019-11-20 17:18 ` [alsa-devel] Applied "ASoC: soc-pcm: remove soc_pcm_private_free()" to the asoc tree Mark Brown
2019-12-05 12:16 ` [alsa-devel] [PATCH 2/2] ASoC: soc-pcm: remove soc_pcm_private_free() Enric Balletbo Serra
2019-12-05 12:54 ` Daniel Baluta
2019-12-05 15:18 ` Enric Balletbo Serra
2019-11-18 15:25 ` [alsa-devel] [PATCH 0/2] ASoC: fixup topology dai_link remove issue Pierre-Louis Bossart
2019-11-19 1:10 ` Kuninori Morimoto
2019-11-19 13:37 ` Pierre-Louis Bossart [this message]
2019-11-19 18:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a63127e6-fbf1-af5e-d4f5-5b98c00040b5@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).