From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
vkoul@kernel.org, broonie@kernel.org,
srinivas.kandagatla@linaro.org, jank@cadence.com,
slawomir.blauciak@intel.com,
Sanyog Kale <sanyog.r.kale@intel.com>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH] soundwire: intel: report slave_ids for each link to SOF driver
Date: Fri, 10 Jan 2020 16:31:24 -0600 [thread overview]
Message-ID: <a70c54c0-c691-d8eb-4f99-da1bb9306c2f@linux.intel.com> (raw)
In-Reply-To: <20200110220016.30887-1-pierre-louis.bossart@linux.intel.com>
On 1/10/20 4:00 PM, Pierre-Louis Bossart wrote:
> From: Bard Liao <yung-chuan.liao@linux.intel.com>
>
> The existing link_mask flag is no longer sufficient to detect the
> hardware and identify which topology file and a machine driver to load.
>
> By reporting the slave_ids exposed in ACPI tables, the parent SOF
> driver will be able to compare against a set of static configurations.
>
> This patch only adds the interface change, the functionality is added
> in future patches.
Vinod, this patch would need to be shared as an immutable tag for Mark,
once this is done I can share the SOF parts that make use of the
information (cf. https://github.com/thesofproject/linux/pull/1692 for
reference)
Sorry we missed this in the earlier interface changes, we didn't think
we would have so many hardware variations so quickly.
Thanks!
>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> include/linux/soundwire/sdw_intel.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/include/linux/soundwire/sdw_intel.h b/include/linux/soundwire/sdw_intel.h
> index 93b83bdf8035..979b41b5dcb4 100644
> --- a/include/linux/soundwire/sdw_intel.h
> +++ b/include/linux/soundwire/sdw_intel.h
> @@ -5,6 +5,7 @@
> #define __SDW_INTEL_H
>
> #include <linux/irqreturn.h>
> +#include <linux/soundwire/sdw.h>
>
> /**
> * struct sdw_intel_stream_params_data: configuration passed during
> @@ -93,6 +94,11 @@ struct sdw_intel_link_res;
> */
> #define SDW_INTEL_CLK_STOP_BUS_RESET BIT(3)
>
> +struct sdw_intel_slave_id {
> + int link_id;
> + struct sdw_slave_id id;
> +};
> +
> /**
> * struct sdw_intel_ctx - context allocated by the controller
> * driver probe
> @@ -101,9 +107,12 @@ struct sdw_intel_link_res;
> * hardware capabilities after all power dependencies are settled.
> * @link_mask: bit-wise mask listing SoundWire links reported by the
> * Controller
> + * @num_slaves: total number of devices exposed across all enabled links
> * @handle: ACPI parent handle
> * @links: information for each link (controller-specific and kept
> * opaque here)
> + * @ids: array of slave_id, representing Slaves exposed across all enabled
> + * links
> * @link_list: list to handle interrupts across all links
> * @shim_lock: mutex to handle concurrent rmw access to shared SHIM registers.
> */
> @@ -111,8 +120,10 @@ struct sdw_intel_ctx {
> int count;
> void __iomem *mmio_base;
> u32 link_mask;
> + int num_slaves;
> acpi_handle handle;
> struct sdw_intel_link_res *links;
> + struct sdw_intel_slave_id *ids;
> struct list_head link_list;
> struct mutex shim_lock; /* lock for access to shared SHIM registers */
> };
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-10 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 22:00 [alsa-devel] [PATCH] soundwire: intel: report slave_ids for each link to SOF driver Pierre-Louis Bossart
2020-01-10 22:31 ` Pierre-Louis Bossart [this message]
2020-01-14 6:26 ` Vinod Koul
2020-01-14 16:05 ` Pierre-Louis Bossart
2020-01-16 12:03 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a70c54c0-c691-d8eb-4f99-da1bb9306c2f@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).