From: Dmitry Osipenko <digetx@gmail.com>
To: David Heidelberg <david@ixit.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, ~okias/devicetree@lists.sr.ht,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: sound: nvidia,tegra-audio: Convert multiple txt bindings to yaml
Date: Thu, 16 Dec 2021 05:52:12 +0300 [thread overview]
Message-ID: <a84213cb-272a-f1b2-338f-ed8ed0bf133d@gmail.com> (raw)
In-Reply-To: <20211211224946.79875-1-david@ixit.cz>
12.12.2021 01:49, David Heidelberg пишет:
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + sound {
> + compatible = "nvidia,tegra-audio-rt5677-ryu",
> + "nvidia,tegra-audio-rt5677";
> + nvidia,model = "NVIDIA Tegra Ryu";
> +
> + nvidia,audio-routing =
> + "Headphone", "LOUT2",
> + "Headphone", "LOUT1",
> + "Headset Mic", "MICBIAS1",
> + "IN1P", "Headset Mic",
> + "IN1N", "Headset Mic",
> + "DMIC L1", "Internal Mic 1",
> + "DMIC R1", "Internal Mic 1",
> + "DMIC L2", "Internal Mic 2",
> + "DMIC R2", "Internal Mic 2",
> + "Speaker", "PDM1L",
> + "Speaker", "PDM1R";
> +
> + nvidia,i2s-controller = <&tegra_i2s1>;
> + nvidia,audio-codec = <&rt5677>;
> +
> + nvidia,hp-det-gpios = <&gpio 143 0>;
> + nvidia,mic-present-gpios = <&gpio 132 1>;
> + nvidia,hp-en-gpios = <&rt5677 1 0>;
> + nvidia,dmic-clk-en-gpios = <&rt5677 2 1>;
I spotted that nvidia,dmic-clk-en-gpios is undocumented, but DTs and
binding are passing the validation. We will make another patch to fix it.
Rob, could you please tell whether this is because unevaluatedProperties
doesn't work yet or we're missing something?
next prev parent reply other threads:[~2021-12-16 2:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-11 22:49 [PATCH v2] dt-bindings: sound: nvidia, tegra-audio: Convert multiple txt bindings to yaml David Heidelberg
2021-12-15 20:01 ` [PATCH v2] dt-bindings: sound: nvidia,tegra-audio: " Rob Herring
2021-12-15 20:25 ` Mark Brown
2021-12-16 2:21 ` [PATCH v2] dt-bindings: sound: nvidia, tegra-audio: " Mark Brown
2021-12-16 2:52 ` Dmitry Osipenko [this message]
2021-12-16 13:44 ` [PATCH v2] dt-bindings: sound: nvidia,tegra-audio: " Thierry Reding
2021-12-16 15:42 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a84213cb-272a-f1b2-338f-ed8ed0bf133d@gmail.com \
--to=digetx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).