* [PATCH] ASoC: qcom: lpass: Fix i2s ctl register bit map
@ 2021-01-19 7:17 Jun Nie
2021-01-19 17:37 ` Srinivas Kandagatla
0 siblings, 1 reply; 3+ messages in thread
From: Jun Nie @ 2021-01-19 7:17 UTC (permalink / raw)
To: srinivas.kandagatla; +Cc: Jun Nie, plai, bgoswami, alsa-devel
Fix bitwidth mapping in i2s ctl register per APQ8016 document.
Signed-off-by: Jun Nie <jun.nie@linaro.org>
---
sound/soc/qcom/lpass-apq8016.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
index 0aedb3a0a798..7c0e774ad062 100644
--- a/sound/soc/qcom/lpass-apq8016.c
+++ b/sound/soc/qcom/lpass-apq8016.c
@@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
.micmode = REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
.micmono = REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
.wssrc = REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
- .bitwidth = REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
+ .bitwidth = REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
.rdma_dyncclk = REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
.rdma_bursten = REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: qcom: lpass: Fix i2s ctl register bit map
2021-01-19 7:17 [PATCH] ASoC: qcom: lpass: Fix i2s ctl register bit map Jun Nie
@ 2021-01-19 17:37 ` Srinivas Kandagatla
2021-01-19 17:43 ` Srinivas Kandagatla
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas Kandagatla @ 2021-01-19 17:37 UTC (permalink / raw)
To: Jun Nie; +Cc: plai, bgoswami, alsa-devel
Thanks for the Patch Jun,
On 19/01/2021 07:17, Jun Nie wrote:
> Fix bitwidth mapping in i2s ctl register per APQ8016 document.
>
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
--srini
> ---
> sound/soc/qcom/lpass-apq8016.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
> index 0aedb3a0a798..7c0e774ad062 100644
> --- a/sound/soc/qcom/lpass-apq8016.c
> +++ b/sound/soc/qcom/lpass-apq8016.c
> @@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
> .micmode = REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
> .micmono = REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
> .wssrc = REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
> - .bitwidth = REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
> + .bitwidth = REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
>
> .rdma_dyncclk = REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
> .rdma_bursten = REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: qcom: lpass: Fix i2s ctl register bit map
2021-01-19 17:37 ` Srinivas Kandagatla
@ 2021-01-19 17:43 ` Srinivas Kandagatla
0 siblings, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2021-01-19 17:43 UTC (permalink / raw)
To: Jun Nie; +Cc: plai, bgoswami, alsa-devel
On 19/01/2021 17:37, Srinivas Kandagatla wrote:
> Thanks for the Patch Jun,
>
> On 19/01/2021 07:17, Jun Nie wrote:
>> Fix bitwidth mapping in i2s ctl register per APQ8016 document.
>>
>> Signed-off-by: Jun Nie <jun.nie@linaro.org>
>
>
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
I sent reply too quickly, just realized that this was a regression from
b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
dmactl registers")
So can you add Fixes tag and resend your patch!
--srini
>
>
> --srini
>
>> ---
>> sound/soc/qcom/lpass-apq8016.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/qcom/lpass-apq8016.c
>> b/sound/soc/qcom/lpass-apq8016.c
>> index 0aedb3a0a798..7c0e774ad062 100644
>> --- a/sound/soc/qcom/lpass-apq8016.c
>> +++ b/sound/soc/qcom/lpass-apq8016.c
>> @@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
>> .micmode = REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
>> .micmono = REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
>> .wssrc = REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
>> - .bitwidth = REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
>> + .bitwidth = REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
>> .rdma_dyncclk = REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
>> .rdma_bursten = REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-19 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 7:17 [PATCH] ASoC: qcom: lpass: Fix i2s ctl register bit map Jun Nie
2021-01-19 17:37 ` Srinivas Kandagatla
2021-01-19 17:43 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).