From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2826C3F2CE for ; Fri, 28 Feb 2020 00:32:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 304932469D for ; Fri, 28 Feb 2020 00:32:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JWovMS8c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 304932469D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 77F2C16D4; Fri, 28 Feb 2020 01:31:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 77F2C16D4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582849938; bh=5mkc9o3CWMJEP6x8PhL0tuZM9/OvBuWxGRKlSVUvLZE=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JWovMS8cv699Ablh+Am7N4mcwePc3dumnfpuHvjzyh70EeT4zf/AOdqkiacPfGQoo +97R/XG1MMRZ6NNlrzOrBDgCJY49VwX1VAOvrRz5QuNjEOftNIf58NDSRvr8Ca/lA+ 8acD1qIo4Xo0XPfTcKNSi+V8ZaXfQkaVMJ/LNcaw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F3D8FF80089; Fri, 28 Feb 2020 01:31:27 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 271E4F80142; Fri, 28 Feb 2020 01:31:26 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D38B0F80089 for ; Fri, 28 Feb 2020 01:31:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D38B0F80089 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 16:31:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,493,1574150400"; d="scan'208";a="230941858" Received: from wggoh-mobl.gar.corp.intel.com (HELO [10.254.45.93]) ([10.254.45.93]) by fmsmga007.fm.intel.com with ESMTP; 27 Feb 2020 16:31:16 -0800 Subject: Re: [alsa-devel] [PATCH AUTOSEL 5.5 406/542] ASoC: SOF: Intel: hda: Fix SKL dai count To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20200214154854.6746-1-sashal@kernel.org> <20200214154854.6746-406-sashal@kernel.org> From: Pierre-Louis Bossart Message-ID: Date: Thu, 27 Feb 2020 18:31:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200214154854.6746-406-sashal@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Cezary Rojewski , Mark Brown , alsa-devel@alsa-project.org, Kai Vehmanen , Ranjani Sridharan X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Sasha, On 2/14/20 9:46 AM, Sasha Levin wrote: > From: Cezary Rojewski > > [ Upstream commit a6947c9d86bcfd61b758b5693eba58defe7fd2ae ] > > With fourth pin added for iDisp for skl_dai, update SOF_SKL_DAI_NUM to > account for the change. Without this, dais from the bottom of the list > are skipped. In current state that's the case for 'Alt Analog CPU DAI'. > > Fixes: ac42b142cd76 ("ASoC: SOF: Intel: hda: Add iDisp4 DAI") This patch generates a kernel oops with v5.5.6 - mainly because the initial commit ac42b142cd76 is missing, which ends-up creating an empty entry in the skl_dai[] array. This was just reported to us, see logs at https://github.com/thesofproject/sof/issues/2418 the same problem is likely to happen with 5.4-stable [PATCH AUTOSEL 5.4 349/459] ASoC: SOF: Intel: hda: Fix SKL dai count Since the initial commit to be fixed was not included, the -stable branches should probably revert this patch? Adding ac42b142cd76 should also not generate any problems, I tested it on top of v5.5.6 The 'right' fix should be to use ARRAY_SIZE instead of hard-coded defines, but there are multiple dependencies so we'd probably need to refactor the code to so so. Let me know if you want more details or additional help, -Pierre > Signed-off-by: Cezary Rojewski > Reviewed-by: Pierre-Louis Bossart > Link: https://lore.kernel.org/r/20200113114054.9716-1-cezary.rojewski@intel.com > Signed-off-by: Mark Brown > Signed-off-by: Sasha Levin > --- > sound/soc/sof/intel/hda.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/intel/hda.h b/sound/soc/sof/intel/hda.h > index 63df888dddb6c..de0115294c74e 100644 > --- a/sound/soc/sof/intel/hda.h > +++ b/sound/soc/sof/intel/hda.h > @@ -348,7 +348,7 @@ > > /* Number of DAIs */ > #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA) > -#define SOF_SKL_NUM_DAIS 14 > +#define SOF_SKL_NUM_DAIS 15 > #else > #define SOF_SKL_NUM_DAIS 8 > #endif >