Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jaroslav Kysela <perex@perex.cz>,
	ALSA development <alsa-devel@alsa-project.org>
Cc: Takashi Iwai <tiwai@suse.de>,
	Cezary Rojewski <cezary.rojewski@intel.com>
Subject: Re: [alsa-devel] [PATCH v3] ALSA: hda: add Intel DSP configuration / probe code
Date: Mon, 7 Oct 2019 11:44:05 -0500
Message-ID: <ad1e5360-6eb6-c22c-b29a-b990447e2d14@linux.intel.com> (raw)
In-Reply-To: <d79e7cdd-2f94-1f00-0025-907682ab9988@perex.cz>


>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_GEMINILAKE)
>>> +	{
>>> +		.flags = FLAG_SOF,
>>
>> can we have more than one table per PCI ID? e.g. in this case it'd be
>> good to have the DMIC case separate from Google.
> 
> Yes, first match wins. So we need to add flags = FLAG_SOF |
> FLAG_SOF_ONLY_IF_DMIC entry bellow the dmi exceptions for device == 0x3198, too?

I need to check this, I am not sure if the firmware (Coreboot or Legacy) 
includes the NHLT definitions.
> 
>>
>>> +		.device = 0x3198,
>>> +		.dmi_table = (const struct dmi_system_id []) {
>>> +			{
>>> +				.ident = "Google Chromebooks",
>>> +				.matches = {
>>> +					DMI_MATCH(DMI_SYS_VENDOR, "Google"),
>>> +				}
>>> +			},
>>> +			{}
>>> +		}
>>> +	},
>>> +#endif
>>> +#if IS_ENABLED(CONFIG_SND_SOC_INTEL_GLK)
>>
>> should it be elif, as done for CometLake/CML?
> 
> I though that the SST driver is the default for 0x3198. Or the legacy driver
> is in the game, too? If yes, we need to add conditional SST entries.

I am not aware of any GLK platform where the SST driver is required.

let me work off-line on a list of quirks that are needed.

> 
>>> +	{
>>> +		.flags = FLAG_SST,
>>> +		.device = 0x3198,
>>> +	},
>>> +#endif
>>> +/* Icelake */
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_ICELAKE)
>>> +	{
>>> +		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC,
>>> +		.device = 0x34c8,
>>> +	},
>>> +#endif
>>> +/* Elkhart Lake */
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_ELKHARTLAKE)
>>> +	{
>>> +		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC,
>>> +		.device = 0x4b55,
>>> +	},
>>> +#endif
>>> +/* Appololake (Broxton-P) */
>>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_APOLLOLAKE)
>>> +	{
>>> +		.flags = FLAG_SOF,
>>> +		.device = 0x5a98,
>>> +		.dmi_table = (const struct dmi_system_id []) {
>>> +			{
>>> +				.ident = "Up Squared",
>>> +				.matches = {
>>> +					DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
>>> +					DMI_MATCH(DMI_BOARD_NAME, "UP-APL01"),
>>> +				}
>>> +			},
>>> +			{}
>>> +		}
>>> +	},
>>> +#endif
>>> +#if IS_ENABLED(CONFIG_SND_SOC_INTEL_APL)
>>
>> elif?
> 
> Same. What's the default driver for APL?

Should be legacy except for Chromebooks where it's SST.

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-06 15:22 Jaroslav Kysela
2019-10-07  1:50 ` Takashi Iwai
2019-10-07 16:13   ` Jaroslav Kysela
2019-10-07 14:05 ` Pierre-Louis Bossart
2019-10-07 16:03   ` Jaroslav Kysela
2019-10-07 16:44     ` Pierre-Louis Bossart [this message]
2019-10-08 18:44     ` Pierre-Louis Bossart
2019-10-09  6:26       ` Jaroslav Kysela

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad1e5360-6eb6-c22c-b29a-b990447e2d14@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=cezary.rojewski@intel.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git