alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Curtis Malainey <cujomalainey@chromium.org>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [alsa-devel] [PATCH 01/11] ucm: docs: Add JackName value
Date: Mon, 11 Nov 2019 11:44:08 +0200 (EET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1911111125240.16459@zeliteleevi> (raw)
In-Reply-To: <20191107015808.26844-1-cujomalainey@chromium.org>

Hi Curtis,

On Wed, 6 Nov 2019, Curtis Malainey wrote:

> This field represents the input device name for a jack detection line
> 
> Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>

this series looks good to me and I think it's a very good idea to bring 
extensions that have proven useful in Chromium to alsa-lib.

For reviewing, a bit of background context and pointers would probably 
help the wider audience. E.g. I found this very useful:

https://www.chromium.org/chromium-os/chromiumos-design-docs/cras-chromeos-audio-server
-> 
https://docs.google.com/document/d/1AcXZI9dvJBW0Vy6h9vraD7VP9X_MpwHx0eJ6hNc4G_s/edit?usp=sharing

Not directly related to this series, but it would be nice if the 
versioning would be aligned as well (especially now as ucmv2 is being 
proposed).

Br, Kai
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-11-11  9:45 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07  1:57 [alsa-devel] [PATCH 01/11] ucm: docs: Add JackName value Curtis Malainey
2019-11-07  1:57 ` [alsa-devel] [PATCH 02/11] ucm: docs: Add JackType value Curtis Malainey
2019-11-11 13:39   ` Jaroslav Kysela
2019-11-29 16:01     ` Jaroslav Kysela
2019-12-03  3:22       ` Curtis Malainey
2019-12-03  8:39         ` Jaroslav Kysela
2019-11-07  1:58 ` [alsa-devel] [PATCH 03/11] ucm: docs: add value JackSwitch Curtis Malainey
2019-11-11 13:30   ` Jaroslav Kysela
2019-11-07  1:58 ` [alsa-devel] [PATCH 04/11] ucm: docs: Add EDID File value Curtis Malainey
2019-11-11 15:18   ` Jaroslav Kysela
2019-11-07  1:58 ` [alsa-devel] [PATCH 05/11] ucm: docs: Add MinBufferLevel value Curtis Malainey
2019-11-11 14:55   ` Jaroslav Kysela
2019-11-11 15:19   ` Jaroslav Kysela
2019-11-07  1:58 ` [alsa-devel] [PATCH 06/11] ucm: docs: Add DisableSoftwareVolume Curtis Malainey
2019-11-11 15:22   ` Jaroslav Kysela
2019-11-11 18:51     ` Curtis Malainey
2019-11-11 19:11       ` Curtis Malainey
2019-11-07  1:58 ` [alsa-devel] [PATCH 07/11] ucm: docs: Add CaptureChannelMap Curtis Malainey
2019-11-11 15:30   ` Jaroslav Kysela
2019-11-11 22:08     ` Curtis Malainey
2019-11-07  1:58 ` [alsa-devel] [PATCH 08/11] " Curtis Malainey
2019-11-07  2:02   ` Curtis Malainey
2019-11-11 15:31   ` Jaroslav Kysela
2019-11-11 22:09     ` Curtis Malainey
2019-11-07  1:58 ` [alsa-devel] [PATCH 09/11] ucm: docs: Add EchoReferenceDev Curtis Malainey
2019-11-11 15:36   ` Jaroslav Kysela
2019-11-11 18:42     ` Curtis Malainey
2019-11-07  1:58 ` [alsa-devel] [PATCH 10/11] ucm: docs: Add SoftwareGain Curtis Malainey
2019-11-11 15:33   ` Jaroslav Kysela
2019-11-11 18:46     ` Curtis Malainey
2019-11-07  1:58 ` [alsa-devel] [PATCH 11/11] ucm: docs: Add DefaultNodeGain Curtis Malainey
2019-11-11 15:34   ` Jaroslav Kysela
2019-11-11 18:44     ` Curtis Malainey
2019-11-11  9:44 ` Kai Vehmanen [this message]
2019-11-11 13:26 ` [alsa-devel] [PATCH 01/11] ucm: docs: Add JackName value Jaroslav Kysela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1911111125240.16459@zeliteleevi \
    --to=kai.vehmanen@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cujomalainey@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).