From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH for-5.6] ALSA: hda: Manage concurrent reg access more properly
Date: Mon, 13 Jan 2020 14:33:10 +0200 (EET) [thread overview]
Message-ID: <alpine.DEB.2.21.2001131425180.2957@eliteleevi.tm.intel.com> (raw)
In-Reply-To: <20200109090104.26073-1-tiwai@suse.de>
Hi,
On Thu, 9 Jan 2020, Takashi Iwai wrote:
> In the commit 8e85def5723e ("ALSA: hda: enable regmap internal
> locking"), we re-enabled the regmap lock due to the reported
> regression that showed the possible concurrent accesses. It was a
> temporary workaround, and there are still a few opened races even
> after the revert. In this patch, we cover those still opened windows
> with a proper mutex lock and disable the regmap internal lock again.
I've been running tests on multiple HDA machines plus submitted the patch
through the GFX CI (that found the original problem) and no issues have
been found. So with that:
Tested-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
One minor nit from checkpatch:
> +/* a helper macro to call @func_call; retry with power-up if failed */
> +#define CALL_RAW_FUNC(codec, func_call) \
> + ({ \
> + int _err = func_call; \
> + if (_err == -EAGAIN) { \
> + _err = snd_hdac_power_up_pm(codec); \
> + if (_err >= 0) \
> + _err = func_call; \
> + snd_hdac_power_down_pm(codec); \
> + } \
> + _err;})
Checkpatch --strict doesn't like this:
ERROR: space required after that ';' (ctx:VxV)
#121: FILE: sound/hda/hdac_regmap.c:450:
+ _err;})
^
Br,
Kai
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-14 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 9:01 [alsa-devel] [PATCH for-5.6] ALSA: hda: Manage concurrent reg access more properly Takashi Iwai
2020-01-13 12:33 ` Kai Vehmanen [this message]
2020-01-13 12:42 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2001131425180.2957@eliteleevi.tm.intel.com \
--to=kai.vehmanen@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).