From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A4AC433E3 for ; Tue, 18 Aug 2020 11:47:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2ADF2075E for ; Tue, 18 Aug 2020 11:47:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="sCzItQ5d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2ADF2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 562D3174C; Tue, 18 Aug 2020 13:46:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 562D3174C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1597751255; bh=c4RTDm+bQDVsVXtTsgxB5+RzarfMd8NXCoaY3rG4YL0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sCzItQ5d1USxuuE8rouP3utVJC3QAb9u13qJMnaOho7QLCQ+1nMC1pj+gOVrF+pBB KEOv9fYZPscRYGl/TdrBSjdRmNV6i4eEyyNHZlujjKgtA+BA1C809Tk19FH7B0z+sK NScXIKWX8crROxlGp1W4F5k/vfte6DzkNE99CbGs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DE260F80228; Tue, 18 Aug 2020 13:46:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 93EC2F8023F; Tue, 18 Aug 2020 13:46:43 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 12B4BF80104 for ; Tue, 18 Aug 2020 13:46:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 12B4BF80104 IronPort-SDR: T11LfDyZsoFXa1rz0Bg5iLsqzhBPfZVxG+dlxS/7RasllP+OMxwxlrZzADkQ/rCBrhTH0vluaI CcpMzlkVQyWg== X-IronPort-AV: E=McAfee;i="6000,8403,9716"; a="155965157" X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="155965157" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 04:46:27 -0700 IronPort-SDR: j87VtALN7VSQc97EPgjRULRXw0y2yHJyT8gk7363BfV7YVOW5Fq/nlRvuUBILX0Rcgi5NKLmi0 7Hd9QSeTXagA== X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="471777754" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 04:46:25 -0700 Date: Tue, 18 Aug 2020 14:45:22 +0300 (EEST) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: Brent Lu Subject: Re: [PATCH v2] ASoC: hdac_hdmi: support 'ELD' mixer In-Reply-To: <20200818004413.12852-1-brent.lu@intel.com> Message-ID: References: <20200814083436.19845-1-brent.lu@intel.com> <20200818004413.12852-1-brent.lu@intel.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Guennadi Liakhovetski , alsa-devel@alsa-project.org, Kai Vehmanen , Liam Girdwood , linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Takashi Iwai , Mark Brown , =?ISO-8859-2?Q?Amadeusz_S=B3awi=F1ski?= X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hey, a general comment first. We are trying to move development to patch_hdmi, but given we still have platforms using hdac_hdmi, this patch seems like a useful addition. On Tue, 18 Aug 2020, Brent Lu wrote: > Add an binary mixer 'ELD' to each HDMI PCM device so user space > could read the ELD data of external HDMI display. Minor spelling fixes: "Add a binary mixer" "so user space can read" > +static int hdac_hdmi_eld_ctl_get(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ [...] > + list_for_each_entry(port, &pcm->port_list, head) { > + eld = &port->eld; > + [...] > + memcpy(ucontrol->value.bytes.data, eld->eld_buffer, > + eld->eld_size); > + break; > + } This is a bit iffy part. If same PCM is connected to multiple receivers, you return ELD data for the first one and ignore the rest. OTOH, this is inline with comment in hdac_hdmi_get_port_from_cvt() in that this pcm-to-many routing is not really supported by the driver now. But jack status reporting is done a port basis, not per PCM/CVTs, so this is not fully aligned. Hmm. Given the proposed patch is aligned with the user-space interface exposed by patch_hdmi.c, I'm ok to go with this. Can you add an explicit comment to explain what is happening above? Br, Kai