From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: alsa-devel@alsa-project.org,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
daniel.baluta@nxp.com, lgirdwood@gmail.com,
pierre-louis.bossart@linux.intel.com, broonie@kernel.org,
ranjani.sridharan@linux.intel.com,
yung-chuan.liao@linux.intel.com
Subject: Re: [PATCH] ASoC: SOF: relax ABI checks and avoid unnecessary warnings
Date: Fri, 12 Feb 2021 11:53:51 +0200 (EET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2102121150290.864696@eliteleevi.tm.intel.com> (raw)
In-Reply-To: <4471ebc1-9c51-7345-12bf-74af55a6bbc2@linux.intel.com>
Hi,
On Fri, 12 Feb 2021, Amadeusz Sławiński wrote:
> On 2/11/2021 6:24 PM, Kai Vehmanen wrote:
> > With recent SOF 1.7 pre-releases, kernel has been emitting following
> > warnings at probe:
> >
> > [10006.645216] sof-audio-pci 0000:00:1f.3: warn: FW ABI is more recent than
> > kernel
> > [10006.652137] sof-audio-pci 0000:00:1f.3: warn: topology ABI is more recent
> > than kernel
[...]
> > --- a/sound/soc/sof/topology.c
> > +++ b/sound/soc/sof/topology.c
> > @@ -3658,7 +3658,7 @@ static int sof_manifest(struct snd_soc_component
> > *scomp, int index,
> > return -EINVAL;
> > }
> > - if (abi_version > SOF_ABI_VERSION) {
> > + if (SOF_ABI_VERSION_MINOR(abi_version) > SOF_ABI_MINOR) {
> > if (!IS_ENABLED(CONFIG_SND_SOC_SOF_STRICT_ABI_CHECKS)) {
> > dev_warn(scomp->dev, "warn: topology ABI is more
> > recent than kernel\n");
> > } else {
> >
> > base-commit: ec9d68508ff65df1dc24cf8100eb40ddd196c2fd
> >
>
> Shouldn't you also look at major version?
> Seems to me like with this check for example 2.1.0 compared to 3.0.0 will
> compare 1 and 0 and tell you that you have too new version. Even if 2 is less
> than 3.
ack on that. The diff is a bit hard to follow as the checks I modify here,
in topology.c and ipc.c, are both preceded by a check with
SOF_ABI_VERSION_INCOMPATIBLE(). If major version doens't match, we return
an error earlier. So thus we only need to check the minor version here.
Br, Kai
prev parent reply other threads:[~2021-02-12 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 17:24 [PATCH] ASoC: SOF: relax ABI checks and avoid unnecessary warnings Kai Vehmanen
2021-02-11 17:51 ` Mark Brown
2021-02-12 8:10 ` Amadeusz Sławiński
2021-02-12 9:53 ` Kai Vehmanen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2102121150290.864696@eliteleevi.tm.intel.com \
--to=kai.vehmanen@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).