From: vishnu <vravulap@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Maruthi Bayyavarapu <maruthi.bayyavarapu@amd.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
open list <linux-kernel@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"Mehta, Sanju" <Sanju.Mehta@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
"RAVULAPATI,
VISHNU VARDHAN RAO" <Vishnuvardhanrao.Ravulapati@amd.com>,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [alsa-devel] [PATCH 3/7] ASoC: amd: Enabling I2S instance in DMA and DAI
Date: Fri, 25 Oct 2019 10:01:37 +0000 [thread overview]
Message-ID: <b020e8fe-d5c1-3544-c2b4-79ff4af3f85e@amd.com> (raw)
In-Reply-To: <20191025095537.GB4209@sirena.co.uk>
On 25/10/19 3:25 PM, Mark Brown wrote:
> On Fri, Oct 25, 2019 at 06:53:16AM +0000, vishnu wrote:
>> On 24/10/19 5:10 PM, Mark Brown wrote:
>>> On Sat, Oct 19, 2019 at 02:35:41AM +0530, Ravulapati Vishnu vardhan rao wrote:
>
>>>> + case I2S_BT_INSTANCE:
>>>> + val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_ITER);
>>>> + val = val | (rtd->xfer_resolution << 3);
>>>> + rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_ITER);
>>>> + break;
>
>>> For some reason the break; isn't indented with the rest of the block.
>>> I'm fairly sure I've mentioned this before...
>
>> Sorry for this but I am not able to find indentation.I have tested with
>> scripts/checkpatch.pl. It shows no warnings.
>
> The break should be aligned with the rest of the block like I said, an
> extra tab in - you can see lots of examples of break statements in the
> kernel.
>
Yes Got it.Thanks for your comments.I will create a separate patch for
fixing this issue.
Regards,
Vishnu
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-25 10:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 21:05 [alsa-devel] [PATCH 1/7] ASoC: amd: Create multiple I2S platform device endpoints Ravulapati Vishnu vardhan rao
2019-10-18 21:05 ` [alsa-devel] [PATCH 2/7] ASoC: amd: Refactoring of DAI from DMA driver Ravulapati Vishnu vardhan rao
2019-10-25 7:06 ` vishnu
2019-10-18 21:05 ` [alsa-devel] [PATCH 3/7] ASoC: amd: Enabling I2S instance in DMA and DAI Ravulapati Vishnu vardhan rao
2019-10-24 11:40 ` Mark Brown
2019-10-25 6:53 ` vishnu
2019-10-25 9:55 ` Mark Brown
2019-10-25 10:01 ` vishnu [this message]
2019-10-25 6:57 ` vishnu
2019-10-18 21:05 ` [alsa-devel] [PATCH 4/7] ASoC: amd: add ACP3x TDM mode support Ravulapati Vishnu vardhan rao
2019-10-25 7:06 ` vishnu
2019-10-18 21:05 ` [alsa-devel] [PATCH 5/7] ASoC: amd: handle ACP3x i2s-sp watermark interrupt Ravulapati Vishnu vardhan rao
2019-10-25 7:07 ` vishnu
2019-10-18 21:05 ` [alsa-devel] [PATCH 6/7] ASoC: amd: ACP powergating should be done by controller Ravulapati Vishnu vardhan rao
2019-10-18 10:39 ` Dan Carpenter
2019-11-06 14:11 ` vishnu
2019-10-18 21:05 ` [alsa-devel] [PATCH 7/7] ASoC: amd: Added ACP3x system resume and runtime pm ops Ravulapati Vishnu vardhan rao
2019-10-25 7:05 ` [alsa-devel] [PATCH 1/7] ASoC: amd: Create multiple I2S platform device endpoints vishnu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b020e8fe-d5c1-3544-c2b4-79ff4af3f85e@amd.com \
--to=vravulap@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Sanju.Mehta@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maruthi.bayyavarapu@amd.com \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).