alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Curtis Malainey <cujomalainey@chromium.org>, alsa-devel@alsa-project.org
Cc: Hui Wang <hui.wang@canonical.com>,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Alexios Zavras <alexios.zavras@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jie Yang <yang.jie@linux.intel.com>,
	Takashi Iwai <tiwai@suse.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Ben Zhang <benzh@chromium.org>, Mac Chiang <mac.chiang@intel.com>,
	Mark Brown <broonie@kernel.org>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Naveen Manohar <naveen.m@intel.com>,
	Bard Liao <bardliao@realtek.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jon Flatley <jflat@chromium.org>,
	Bard liao <yung-chuan.liao@linux.intel.com>,
	Allison Randal <allison@lohutok.net>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: intel: Add Broadwell rt5650 machine driver
Date: Wed, 4 Dec 2019 22:09:57 -0600	[thread overview]
Message-ID: <b2eb65e3-d9ee-f6ed-197b-c40d90ab1e8d@linux.intel.com> (raw)
In-Reply-To: <20191205001605.229405-1-cujomalainey@chromium.org>



On 12/4/19 6:15 PM, Curtis Malainey wrote:
> From: Ben Zhang <benzh@chromium.org>
> 
> Add machine driver for Broadwell + rt5650.
> 
> v2 (Curtis):
> * Addressed Pierre's comments
>    * Added SOF dependencies
>    * Added platform override
>    * Fixed Kconfig
> * Moved to devm register

you want the version info below the --- mark

> 
> Signed-off-by: Bard Liao <bardliao@realtek.com>

Not sure what the recommendation is when an address is no longer valid?

> +static struct platform_driver bdw_rt5650_audio = {
> +	.probe = bdw_rt5650_probe,
> +	.driver = {
> +		.name = "bdw-rt5650",
> +		.owner = THIS_MODULE,

this .owner is not needed.

The rest looks good
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-12-05  4:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05  0:15 [alsa-devel] [PATCH v2] ASoC: intel: Add Broadwell rt5650 machine driver Curtis Malainey
2019-12-05  1:22 ` Ranjani Sridharan
2019-12-05  9:19   ` Mark Brown
2019-12-05 19:03   ` Curtis Malainey
2019-12-05 21:18     ` Ranjani Sridharan
2019-12-05  4:09 ` Pierre-Louis Bossart [this message]
2019-12-05  9:20   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2eb65e3-d9ee-f6ed-197b-c40d90ab1e8d@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alexios.zavras@intel.com \
    --cc=allison@lohutok.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=bardliao@realtek.com \
    --cc=benzh@chromium.org \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=cujomalainey@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hui.wang@canonical.com \
    --cc=jflat@chromium.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=krzk@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=mac.chiang@intel.com \
    --cc=naveen.m@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.com \
    --cc=yang.jie@linux.intel.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).