From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041C3C5DF63 for ; Wed, 6 Nov 2019 18:10:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1E6F217F5 for ; Wed, 6 Nov 2019 18:10:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="CJkcsu4I"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="deTo+90l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1E6F217F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C351D846; Wed, 6 Nov 2019 19:09:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C351D846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1573063843; bh=O1ozRCRFTmK+0Gk+4JgpSDIkz84cxToQvN8AiFi61ho=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CJkcsu4IlPlM06P4u/8AbcF3KIbO93KAec2KAy1Cj95dJzZDpuaJ1pslFhL1GUAcw HMaX5O62T5Y6lhCQxEtW5IOP8d9y2fJa3NwoC0XqP42JTlIPVDW0IP7rYMCQ7hs8sJ eeQsVRB8DBWKh1DyEhqEiebREQ36DIbSG4Ua++QI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 59B78F80321; Wed, 6 Nov 2019 19:09:53 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A3C0FF803D0; Wed, 6 Nov 2019 19:09:51 +0100 (CET) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D6E83F800F3 for ; Wed, 6 Nov 2019 19:09:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D6E83F800F3 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="deTo+90l" Received: by mail-wm1-x343.google.com with SMTP id x4so4790242wmi.3 for ; Wed, 06 Nov 2019 10:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rgJXsUBNZa/F0SLsO+it3k7f9qVrt3VaEEsEU5U0WF4=; b=deTo+90lJ6be7HHxTg00sHjXhZ3BCSqrIZB22Zr4Ih0eXfNoJ6Gwt/RbEw5gQSjgIg qidpwKs5uRX2/lu5DRzqXig8ftmUi03AhVaEYUpWJ0jjW9auDFhXL1SkjGYGBmto2pb8 veFrOCGDVpD9USl2jXCi2MXpsVt0aBgUqTgiEF6etTbJSDsHDbDcWFVFy6vonpSHsMI7 L2D0mmBoCGDPshPuZzY4p7VQhtH6IXIpaaGTfk6LPUmiJgvxFMYwzdxm8qdcFIcjlA9c b7kkPdCm7cyF1fB5SXXtiruwEQBPAIdGxrexuet+sitv4fmBS9v4vcbQa8fKE9swANAS tp6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rgJXsUBNZa/F0SLsO+it3k7f9qVrt3VaEEsEU5U0WF4=; b=msMUP9/GIii7K+1Shj/ccum1Lg4neI7EMn+h6NMvOfTVEkp7RpJCDA66g93VydwVlF vwzNmO1N79voj/vPUb4RBo1bxl3d+Wq9wmkFwrXKnky50Q2m4RkIcoFjJQ0UD3oOHJrJ ndlegA57+YMg4J2WH42kZWHzhb4Dv5nfHPCTXidrbuKjXH0i/r+JDz8L/Qy7qi5e0I+p L+k0AuigyxSPcmaihjOP1AV1htgtXpsgKLuK4bhm7zOsUKt4RdLVbgqGN2zrj8RG1xoU C4SrnMWJ6k7OGvPbu10FDIOX0unkShmu8ueNA8DhSeNKv78BpS40px6pS1vv1TIB5Vw+ 91Lg== X-Gm-Message-State: APjAAAWgDVxuqvbjB4bPLtxai7wJgWhFEaPbOVgnLrVVbp/YyMBKB97F l/TIKcwbstJBhuPYXWs6b6YQAA== X-Google-Smtp-Source: APXvYqwuEOoV5aCzLlGkVZlVwso0Ano0flwVy5rE6QbRo8vNmNb2jFk7drTtQSJedQIw1NCPZ+6geA== X-Received: by 2002:a1c:6a0d:: with SMTP id f13mr3948924wmc.164.1573063784694; Wed, 06 Nov 2019 10:09:44 -0800 (PST) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id r19sm29208269wrr.47.2019.11.06.10.09.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Nov 2019 10:09:43 -0800 (PST) To: Rob Herring References: <20191018001849.27205-1-srinivas.kandagatla@linaro.org> <20191018001849.27205-2-srinivas.kandagatla@linaro.org> <20191025204338.GA25892@bogus> <90b2d83b-f2b2-3a5d-4deb-589f4b48b208@linaro.org> <371955d9-ad2d-5ddc-31b4-710729feae42@linaro.org> <7811be04-dfda-5953-110c-bca685fdcaa4@linaro.org> From: Srinivas Kandagatla Message-ID: Date: Wed, 6 Nov 2019 18:09:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: devicetree@vger.kernel.org, Linux-ALSA , Banajit Goswami , Vinod Koul , Linus Walleij , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Mark Brown , Lee Jones , spapothi@codeaurora.org Subject: Re: [alsa-devel] [PATCH v2 01/11] ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 05/11/2019 19:08, Rob Herring wrote: > On Wed, Oct 30, 2019 at 4:55 AM Srinivas Kandagatla > wrote: >> >> >> >> On 29/10/2019 20:47, Rob Herring wrote: >>> On Mon, Oct 28, 2019 at 7:45 AM Srinivas Kandagatla >>> wrote: >>>> >>>> >>>> >>>> On 28/10/2019 12:40, Srinivas Kandagatla wrote: >>>>> Its Phandle. >>>>> >>>>> something like this is okay? >>>>> >>>>> slim-ifc-dev: >>>>> $ref: '/schemas/types.yaml#/definitions/phandle-array' >>>> >>>> Sorry this should not be an array, so something like this: >>>> >>>> slim-ifc-dev: >>>> description: SLIMBus Interface device phandle >>> >>> You're just spelling out the abbreviated name. I can do that much. >>> What is 'SLIMBus Interface device'? >> >> Each SLIMBus Component contains one Interface Device. Which is >> responsible for Monitoring and reporting the status of component, Data >> line to Data pin connection setup for SLIMBus streaming. Interface >> device is enumerated just like any other slim device. > > So a standard set of registers every slimbus device has? In hindsight, > I would have made reg have 2 entries with both addresses. I guess that > ship has sailed. That will break SLIMBus bindings, Which is expecting one device per device node. > > It seems strange you would need both "devices" described as separate > nodes in DT. Because they are two different devices on the SLIMBus Component. > >> >> We already have exactly same bindings for WCD9335 in upstream at: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt?h=v5.4-rc5#n42 >> >>> >>> Is it a standard SLIMBus property? If so, document it in the right >>> place. If not, then needs a vendor prefix. >> >> "SLIMBus Interface Device" itself is documented in SLIMBus Specification. >> >> If I remember it correctly You suggested me to move to "slim-ifc-dev" >> as this is part of SLIMBus Specification. > > Probably so. If it is common, then document it in bindings/slimbus/bus.txt. > As we are dealing with audio codecs here, it might be that "slim-ifc-dev" is common across wcd9335 and wcd934x but not all devices on the SLIMBus Component would need handle to interface device. SLIMbus can also be used for control buses as well which might not need this. > Then here, 'slim-ifc-dev: true' is sufficient. You can just assume we > convert bus.txt to schema (or feel free to do that :) ). We need phandle to the interface device so that we can program the streaming parameters for the SLIMBus Component. --srini > > Rob > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel