From: "Rojewski, Cezary" <cezary.rojewski@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Singh, Guneshwor O" <guneshwor.o.singh@intel.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Jie Yang <yang.jie@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Subject: RE: [PATCH] ASoC: Intel: fix error code cnl_set_dsp_D0()
Date: Mon, 14 Dec 2020 09:08:44 +0000 [thread overview]
Message-ID: <b3df1e4d04c84b02939321c6994ec978@intel.com> (raw)
In-Reply-To: <X9NEvCzuN+IObnTN@mwanda>
On 2020-12-11 11:06 AM, Dan Carpenter wrote:
> Return -ETIMEDOUT if the dsp boot times out instead of returning
> success.
>
> Fixes: cb6a55284629 ("ASoC: Intel: cnl: Add sst library functions for cnl platform")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Not tested.
>
> sound/soc/intel/skylake/cnl-sst.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/intel/skylake/cnl-sst.c b/sound/soc/intel/skylake/cnl-sst.c
> index fcd8dff27ae8..1275c149acc0 100644
> --- a/sound/soc/intel/skylake/cnl-sst.c
> +++ b/sound/soc/intel/skylake/cnl-sst.c
> @@ -224,6 +224,7 @@ static int cnl_set_dsp_D0(struct sst_dsp *ctx, unsigned int core_id)
> "dsp boot timeout, status=%#x error=%#x\n",
> sst_dsp_shim_read(ctx, CNL_ADSP_FW_STATUS),
> sst_dsp_shim_read(ctx, CNL_ADSP_ERROR_CODE));
> + ret = -ETIMEDOUT;
> goto err;
> }
> } else {
>
Thanks for the patch, Dan.
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
next prev parent reply other threads:[~2020-12-14 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 10:06 [PATCH] ASoC: Intel: fix error code cnl_set_dsp_D0() Dan Carpenter
2020-12-14 9:08 ` Rojewski, Cezary [this message]
2020-12-14 18:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3df1e4d04c84b02939321c6994ec978@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=guneshwor.o.singh@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).