From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A397CC282DD for ; Fri, 10 Jan 2020 16:12:48 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30D4C20838 for ; Fri, 10 Jan 2020 16:12:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="pUeGjzC2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30D4C20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 22CB716BB; Fri, 10 Jan 2020 17:11:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 22CB716BB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1578672766; bh=7Wlj38VJ4cX5mYLtgQDACY/wyeHfixorK8EgdxpIkVY=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pUeGjzC21T4EmXHB0QG3m26Eu/fUHrbQFv5B3eBUeq8VOZHkB84D6nrIWjG7sVywh L7MJphXTsl+ZAnxjE8vSH7KUn67zAiJkushr8iRoSpkSUKWT5Dptibk/2ci2qomQmq 5RLKAQXNTAiWtcheSItT7fTAdBGv8RvkyBjQTnyw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AD681F80116; Fri, 10 Jan 2020 17:11:55 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1FD1BF8011C; Fri, 10 Jan 2020 17:11:55 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4B040F8010B for ; Fri, 10 Jan 2020 17:11:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4B040F8010B X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 08:11:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,417,1571727600"; d="scan'208";a="224236636" Received: from nehudak-mobl1.amr.corp.intel.com (HELO [10.251.145.164]) ([10.251.145.164]) by orsmga003.jf.intel.com with ESMTP; 10 Jan 2020 08:11:47 -0800 To: Vinod Koul References: <20200108175438.13121-1-pierre-louis.bossart@linux.intel.com> <20200108175438.13121-5-pierre-louis.bossart@linux.intel.com> <20200110065515.GZ2818@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: Date: Fri, 10 Jan 2020 10:11:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200110065515.GZ2818@vkoul-mobl> Content-Language: en-US Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Bard liao , Rander Wang Subject: Re: [alsa-devel] [PATCH 4/6] soundwire: stream: do not update parameters during DISABLED-PREPARED transition X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> + /* >> + * when the stream is DISABLED, this means sdw_prepare_stream() >> + * is called as a result of an underflow or a resume operation. >> + * In this case, the bus parameters shall not be recomputed, but >> + * still need to be re-applied >> + */ >> + if (stream->state == SDW_STREAM_DISABLED) >> + update_params = false; > > Should this not be handled by the caller..? I do not like to deduce this > here as the info is already available in dai driver, so go ahead and > propagate it and get it from caller when it is required.. No, this update_params boolean is used later on to modify the bandwidth computation. These values are not accessible to the caller (and should absolutely be kept private/opaque). _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel