From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: Stefan Binding <sbinding@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Lucas Tanure <tanureal@opensource.cirrus.com>
Subject: Re: [PATCH 1/2] ALSA: hda: cs35l41: Don't return -EINVAL from system suspend/resume
Date: Thu, 5 Jan 2023 11:14:13 +0100 [thread overview]
Message-ID: <b99d78df-8087-5a18-a6ea-b83bf1446092@leemhuis.info> (raw)
In-Reply-To: <20230105093531.16960-1-tiwai@suse.de>
On 05.01.23 10:35, Takashi Iwai wrote:
> The recent commit to support the system suspend for CS35L41 caused a
> regression on the models with CS35L41_EXT_BOOST_NO_VSPK_SWITC boost
> type, as the suspend/resume callbacks just return -EINVAL. This is
> eventually handled as a fatal error and blocks the whole system
> suspend/resume.
>
> For avoiding the problem, this patch corrects the return code from
> cs35l41_system_suspend() and _resume() to 0, and replace dev_err()
> with dev_err_once() for stop spamming too much.
>
> Fixes: 88672826e2a4 ("ALSA: hda: cs35l41: Support System Suspend")
> Cc: <stable@vger.kernel.org>
Thx for taking care of that.
> Link: https://lore.kernel.org/r/4262e3c4-6169-bbd2-e918-16b06f6994bc@protonmail.com
Lore says "Not found". I wonder if it was a private mail later send
again here:
https://lore.kernel.org/all/e6751ac2-34f3-d13f-13db-8174fade8308@pm.me/
Ciao, Thorsten
next prev parent reply other threads:[~2023-01-05 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 9:35 [PATCH 1/2] ALSA: hda: cs35l41: Don't return -EINVAL from system suspend/resume Takashi Iwai
2023-01-05 9:35 ` [PATCH 2/2] ALSA: hda: cs35l41: Check runtime suspend capability at runtime_idle Takashi Iwai
2023-01-05 10:14 ` Thorsten Leemhuis [this message]
2023-01-05 13:33 ` [PATCH 1/2] ALSA: hda: cs35l41: Don't return -EINVAL from system suspend/resume Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b99d78df-8087-5a18-a6ea-b83bf1446092@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=alsa-devel@alsa-project.org \
--cc=rf@opensource.cirrus.com \
--cc=sbinding@opensource.cirrus.com \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).