archive mirror
 help / color / mirror / Atom feed
From: Thorsten Leemhuis <>
To: Takashi Iwai <>,
Cc: Stefan Binding <>,
	Richard Fitzgerald <>,
	Lucas Tanure <>
Subject: Re: [PATCH 1/2] ALSA: hda: cs35l41: Don't return -EINVAL from system suspend/resume
Date: Thu, 5 Jan 2023 11:14:13 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 05.01.23 10:35, Takashi Iwai wrote:
> The recent commit to support the system suspend for CS35L41 caused a
> regression on the models with CS35L41_EXT_BOOST_NO_VSPK_SWITC boost
> type, as the suspend/resume callbacks just return -EINVAL.  This is
> eventually handled as a fatal error and blocks the whole system
> suspend/resume.
> For avoiding the problem, this patch corrects the return code from
> cs35l41_system_suspend() and _resume() to 0, and replace dev_err()
> with dev_err_once() for stop spamming too much.
> Fixes: 88672826e2a4 ("ALSA: hda: cs35l41: Support System Suspend")
> Cc: <>

Thx for taking care of that.

> Link:

Lore says "Not found". I wonder if it was a private mail later send
again here:

Ciao, Thorsten

  parent reply	other threads:[~2023-01-05 10:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05  9:35 [PATCH 1/2] ALSA: hda: cs35l41: Don't return -EINVAL from system suspend/resume Takashi Iwai
2023-01-05  9:35 ` [PATCH 2/2] ALSA: hda: cs35l41: Check runtime suspend capability at runtime_idle Takashi Iwai
2023-01-05 10:14 ` Thorsten Leemhuis [this message]
2023-01-05 13:33   ` [PATCH 1/2] ALSA: hda: cs35l41: Don't return -EINVAL from system suspend/resume Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).