From: Dan Murphy <dmurphy@ti.com>
To: Camel Guo <camel.guo@axis.com>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <tiwai@suse.com>, <robh+dt@kernel.org>,
<devicetree@vger.kernel.org>
Cc: alsa-devel@alsa-project.org, kernel@axis.com,
linux-kernel@vger.kernel.org, Camel Guo <camelg@axis.com>
Subject: Re: [PATCH v3 2/2] ASoC: tlv320adcx140: Add support for configuring GPIO pin
Date: Thu, 17 Sep 2020 06:42:02 -0500 [thread overview]
Message-ID: <b9b0a159-905b-6d18-6b7c-db63c2f61c0d@ti.com> (raw)
In-Reply-To: <20200916075949.28479-2-camel.guo@axis.com>
Camel
On 9/16/20 2:59 AM, Camel Guo wrote:
> From: Camel Guo <camelg@axis.com>
>
> Add support to configure the GPIO pin to the specific configuration.
> The GPIO pin can be configured as GPO, IRQ, SDOUT2, PDMCLK, MICBASE_EN,
> GPI, MCLK, SDIN, PDMDIN1, PDMDIN2, PDMDIN3 or PDMDIN4 and the output
> drive can be configured with various configuration.
>
> Signed-off-by: Camel Guo <camelg@axis.com>
> ---
> v3:
> - Add ADCX140_NUM_GPIO_CFGS avoiding using magic number
> - Remove unneeded check on ret in adcx140_configure_gpio
>
> sound/soc/codecs/tlv320adcx140.c | 40 ++++++++++++++++++++++++++++++++
> sound/soc/codecs/tlv320adcx140.h | 5 ++++
> 2 files changed, 45 insertions(+)
>
> diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv320adcx140.c
> index f33ee604ee78..fe6fc6df66cc 100644
> --- a/sound/soc/codecs/tlv320adcx140.c
> +++ b/sound/soc/codecs/tlv320adcx140.c
> @@ -837,6 +837,42 @@ static int adcx140_configure_gpo(struct adcx140_priv *adcx140)
>
> }
>
> +static int adcx140_configure_gpio(struct adcx140_priv *adcx140)
> +{
> + int gpio_count = 0;
> + u32 gpio_outputs[ADCX140_NUM_GPIO_CFGS];
> + u32 gpio_output_val = 0;
> + int ret;
> +
> + gpio_count = device_property_count_u32(adcx140->dev,
> + "ti,gpio-config");
> + if (gpio_count == 0)
> + return 0;
> +
> + if (gpio_count != ADCX140_NUM_GPIO_CFGS)
> + return -EINVAL;
> +
> + ret = device_property_read_u32_array(adcx140->dev, "ti,gpio-config",
> + gpio_outputs, gpio_count);
> + if (ret)
> + return ret;
> +
> + if (gpio_outputs[0] > ADCX140_GPIO_CFG_MAX) {
> + dev_err(adcx140->dev, "GPIO config out of range\n");
> + return -EINVAL;
> + }
> +
> + if (gpio_outputs[1] > ADCX140_GPIO_DRV_MAX) {
> + dev_err(adcx140->dev, "GPIO drive out of range\n");
> + return -EINVAL;
> + }
> +
> + gpio_output_val = gpio_outputs[0] << ADCX140_GPIO_SHIFT
> + | gpio_outputs[1];
> +
> + return regmap_write(adcx140->regmap, ADCX140_GPIO_CFG0, gpio_output_val);
> +}
> +
> static int adcx140_codec_probe(struct snd_soc_component *component)
> {
> struct adcx140_priv *adcx140 = snd_soc_component_get_drvdata(component);
> @@ -934,6 +970,10 @@ static int adcx140_codec_probe(struct snd_soc_component *component)
> return ret;
> }
>
> + ret = adcx140_configure_gpio(adcx140);
> + if (ret)
> + return ret;
> +
> ret = adcx140_configure_gpo(adcx140);
> if (ret)
> goto out;
> diff --git a/sound/soc/codecs/tlv320adcx140.h b/sound/soc/codecs/tlv320adcx140.h
> index eedbc1d7221f..9d04dec374d1 100644
> --- a/sound/soc/codecs/tlv320adcx140.h
> +++ b/sound/soc/codecs/tlv320adcx140.h
> @@ -145,4 +145,9 @@
> #define ADCX140_GPO_CFG_MAX 4
> #define ADCX140_GPO_DRV_MAX 5
>
> +#define ADCX140_NUM_GPIO_CFGS 2
> +#define ADCX140_GPIO_SHIFT 4
> +#define ADCX140_GPIO_CFG_MAX 15
> +#define ADCX140_GPIO_DRV_MAX 5
> +
> #endif /* _TLV320ADCX140_ */
Acked-by: Dan Murphy <dmurphy@ti.com>
next prev parent reply other threads:[~2020-09-17 11:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 7:59 [PATCH v3 1/2] dt-bindings: tlv320adcx140: Add GPIO config and drive config Camel Guo
2020-09-16 7:59 ` [PATCH v3 2/2] ASoC: tlv320adcx140: Add support for configuring GPIO pin Camel Guo
2020-09-17 11:42 ` Dan Murphy [this message]
2020-09-17 15:38 ` Mark Brown
2020-09-21 16:58 ` [PATCH v3 1/2] dt-bindings: tlv320adcx140: Add GPIO config and drive config Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9b0a159-905b-6d18-6b7c-db63c2f61c0d@ti.com \
--to=dmurphy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=camel.guo@axis.com \
--cc=camelg@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).