From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz,
tiwai@suse.com, rohitkr@codeaurora.org,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
swboyd@chromium.org, judyhsiao@chromium.org
Cc: Venkata Prasad Potturu <potturu@codeaurora.org>
Subject: Re: [PATCH 3/7] ASoC: codecs: tx-macro: Change mic control registers to volatile
Date: Mon, 20 Sep 2021 14:24:56 +0100 [thread overview]
Message-ID: <c1c7b1e8-98f5-99a3-1374-11d1d61535b4@linaro.org> (raw)
In-Reply-To: <1632123331-2425-4-git-send-email-srivasam@codeaurora.org>
On 20/09/2021 08:35, Srinivasa Rao Mandadapu wrote:
> Update amic and dmic related tx macro control registers to volatile
>
> Fixes: c39667ddcfc5 (ASoC: codecs: lpass-tx-macro: add support for lpass tx macro)
>
> Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> ---
> sound/soc/codecs/lpass-tx-macro.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/sound/soc/codecs/lpass-tx-macro.c b/sound/soc/codecs/lpass-tx-macro.c
> index 9273724..e65b592 100644
> --- a/sound/soc/codecs/lpass-tx-macro.c
> +++ b/sound/soc/codecs/lpass-tx-macro.c
> @@ -423,6 +423,13 @@ static bool tx_is_volatile_register(struct device *dev, unsigned int reg)
> case CDC_TX_TOP_CSR_SWR_DMIC1_CTL:
> case CDC_TX_TOP_CSR_SWR_DMIC2_CTL:
> case CDC_TX_TOP_CSR_SWR_DMIC3_CTL:
> + case CDC_TX_TOP_CSR_SWR_AMIC0_CTL:
> + case CDC_TX_TOP_CSR_SWR_AMIC1_CTL:
> + case CDC_TX_CLK_RST_CTRL_MCLK_CONTROL:
> + case CDC_TX_CLK_RST_CTRL_FS_CNT_CONTROL:
> + case CDC_TX_CLK_RST_CTRL_SWR_CONTROL:
> + case CDC_TX_TOP_CSR_SWR_CTRL:
> + case CDC_TX0_TX_PATH_SEC7:
Why are these marked as Volatile?
Can you provide some details on the issue that you are seeing?
--srini
> return true;
> }
> return false;
> @@ -1674,6 +1681,12 @@ static int tx_macro_component_probe(struct snd_soc_component *comp)
>
> snd_soc_component_update_bits(comp, CDC_TX0_TX_PATH_SEC7, 0x3F,
> 0x0A);
> + snd_soc_component_update_bits(comp, CDC_TX_TOP_CSR_SWR_AMIC0_CTL, 0xFF, 0x00);
> + snd_soc_component_update_bits(comp, CDC_TX_TOP_CSR_SWR_AMIC1_CTL, 0xFF, 0x00);
> + snd_soc_component_update_bits(comp, CDC_TX_TOP_CSR_SWR_DMIC0_CTL, 0xFF, 0x00);
> + snd_soc_component_update_bits(comp, CDC_TX_TOP_CSR_SWR_DMIC1_CTL, 0xFF, 0x00);
> + snd_soc_component_update_bits(comp, CDC_TX_TOP_CSR_SWR_DMIC2_CTL, 0xFF, 0x00);
> + snd_soc_component_update_bits(comp, CDC_TX_TOP_CSR_SWR_DMIC3_CTL, 0xFF, 0x00);
>
> return 0;
> }
>
next prev parent reply other threads:[~2021-09-20 13:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 7:35 [PATCH 0/7] Update Lpass digital codec macro drivers Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 1/7] ASoC: qcom: Add compatible names in va, wsa, rx, tx codec drivers for sc7280 Srinivasa Rao Mandadapu
2021-09-20 18:17 ` [PATCH 1/7] ASoC: qcom: Add compatible names in va,wsa,rx,tx " Stephen Boyd
2021-09-21 8:42 ` Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 2/7] ASoC: qcom: dt-bindings: Add compatible names for lpass sc7280 digital codecs Srinivasa Rao Mandadapu
2021-09-20 13:24 ` Srinivas Kandagatla
2021-09-21 6:59 ` Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 3/7] ASoC: codecs: tx-macro: Change mic control registers to volatile Srinivasa Rao Mandadapu
2021-09-20 13:24 ` Srinivas Kandagatla [this message]
2021-09-21 7:30 ` Srinivasa Rao Mandadapu
2021-09-21 8:48 ` Srinivas Kandagatla
2021-09-21 13:02 ` Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 4/7] ASoC: codecs: lpass-va-macro: Change bulk voting to individual clock voting Srinivasa Rao Mandadapu
2021-09-20 13:25 ` Srinivas Kandagatla
2021-09-21 8:14 ` Srinivasa Rao Mandadapu
2021-09-21 8:50 ` Srinivas Kandagatla
2021-09-21 12:25 ` Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 5/7] ASoC: codecs: lpass-rx-macro: " Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 6/7] ASoC: codecs: lpass-tx-macro: " Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 7/7] ASoC: codecs: lpass-va-macro: set mclk clock rate correctly Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1c7b1e8-98f5-99a3-1374-11d1d61535b4@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=potturu@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srivasam@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).