From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: jack.yu@realtek.com, broonie@kernel.org, lgirdwood@gmail.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
lars@metafoo.de, kent_chen@realtek.com, kenny_chen@realtek.com,
derek.fang@realtek.com, shumingf@realtek.com, flove@realtek.com
Subject: Re: [PATCH] ASoC: rt1015p: add acpi device id for rt1015p
Date: Thu, 25 Feb 2021 11:15:25 -0600 [thread overview]
Message-ID: <c8ba7a3b-f903-18ac-aeba-b91e180d9878@linux.intel.com> (raw)
In-Reply-To: <20210225084545.13359-1-jack.yu@realtek.com>
> +static const struct acpi_device_id rt1015p_acpi_match[] = {
> + { "RT1015", 0},
This is not an ACPI compliant HID, please don't do this. acpica-tools
will flag an error on this.
And this is super confusing since you already have this in rt1015.c
static struct acpi_device_id rt1015_acpi_match[] = {
{"10EC1015", 0,},
{},
};
next prev parent reply other threads:[~2021-02-25 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 8:45 [PATCH] ASoC: rt1015p: add acpi device id for rt1015p jack.yu
2021-02-25 9:40 ` Tzung-Bi Shih
2021-02-25 17:15 ` Pierre-Louis Bossart [this message]
2021-02-26 2:05 jack.yu
2021-02-26 21:48 ` Pierre-Louis Bossart
2021-03-08 6:10 ` Jack Yu
2021-03-09 20:26 ` Pierre-Louis Bossart
2021-03-10 2:09 ` Jack Yu
2021-03-10 15:39 ` Pierre-Louis Bossart
2021-03-12 20:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8ba7a3b-f903-18ac-aeba-b91e180d9878@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=kenny_chen@realtek.com \
--cc=kent_chen@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).