alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	alsa-devel@alsa-project.org,  tiwai@suse.de
Cc: libin.yang@intel.com
Subject: Re: [alsa-devel] [PATCH v3 05/10] ASoC: Intel: skl-hda-dsp-generic: use snd-hda-codec-hdmi
Date: Tue, 10 Sep 2019 15:49:07 -0500	[thread overview]
Message-ID: <ccc1a764-532d-e21f-dd79-022699076154@linux.intel.com> (raw)
In-Reply-To: <20190910182916.29693-6-kai.vehmanen@linux.intel.com>



On 9/10/19 1:29 PM, Kai Vehmanen wrote:
> Add support for using snd-hda-codec-hdmi driver for HDMI/DP
> instead of ASoC hdac-hdmi. This is aligned with how other
> HDA codecs are already handled.
> 
> When snd-hda-codec-hdmi is used, the PCM device numbers are
> parsed from card topology and passed to the codec driver.
> This needs to be done at runtime as topology changes may
> affect PCM device allocation.
> 
> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> ---
>   include/sound/soc-acpi.h                     |  2 +
>   sound/soc/intel/boards/hda_dsp_common.h      | 87 ++++++++++++++++++++
>   sound/soc/intel/boards/skl_hda_dsp_common.c  | 10 ++-
>   sound/soc/intel/boards/skl_hda_dsp_common.h  | 23 ++++++
>   sound/soc/intel/boards/skl_hda_dsp_generic.c |  1 +
>   5 files changed, 122 insertions(+), 1 deletion(-)
>   create mode 100644 sound/soc/intel/boards/hda_dsp_common.h
> 
> diff --git a/include/sound/soc-acpi.h b/include/sound/soc-acpi.h
> index 35b38e41e5b2..26d57bc9a91e 100644
> --- a/include/sound/soc-acpi.h
> +++ b/include/sound/soc-acpi.h
> @@ -60,12 +60,14 @@ static inline struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg)
>    * @acpi_ipc_irq_index: used for BYT-CR detection
>    * @platform: string used for HDaudio codec support
>    * @codec_mask: used for HDAudio support
> + * @common_hdmi_codec_drv: use commom HDAudio HDMI codec driver
>    */
>   struct snd_soc_acpi_mach_params {
>   	u32 acpi_ipc_irq_index;
>   	const char *platform;
>   	u32 codec_mask;
>   	u32 dmic_num;
> +	bool common_hdmi_codec_drv;

That change would need to be moved to a separate patch earlier to avoid 
breaking compilation of patch 4
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-09-10 20:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 18:29 [alsa-devel] [PATCH v3 00/10] adapt SOF to use snd-hda-codec-hdmi Kai Vehmanen
2019-09-10 18:29 ` [alsa-devel] [PATCH v3 01/10] ALSA: hda/hdmi - implement mst_no_extra_pcms flag Kai Vehmanen
2019-09-10 20:33   ` Pierre-Louis Bossart
2019-09-12  8:28     ` Kai Vehmanen
2019-09-10 18:29 ` [alsa-devel] [PATCH v3 02/10] ALSA: hda/hdmi - allow control creation without a linked pcm Kai Vehmanen
2019-09-10 20:31   ` Pierre-Louis Bossart
2019-09-12  8:16     ` Kai Vehmanen
2019-09-10 18:29 ` [alsa-devel] [PATCH v3 03/10] ASoC: hdac_hda: add support for HDMI/DP as a HDA codec Kai Vehmanen
2019-09-10 20:36   ` Pierre-Louis Bossart
2019-09-12  9:58     ` Kai Vehmanen
2019-09-10 18:29 ` [alsa-devel] [PATCH v3 04/10] ASoC: SOF: Intel: add support for snd-hda-codec-hdmi Kai Vehmanen
2019-09-10 20:52   ` Pierre-Louis Bossart
2019-09-12 12:06     ` Kai Vehmanen
2019-09-12 13:29       ` Pierre-Louis Bossart
2019-09-10 18:29 ` [alsa-devel] [PATCH v3 05/10] ASoC: Intel: skl-hda-dsp-generic: use snd-hda-codec-hdmi Kai Vehmanen
2019-09-10 20:49   ` Pierre-Louis Bossart [this message]
2019-09-10 18:29 ` [alsa-devel] [PATCH v3 06/10] ASoC: Intel: skl-hda-dsp-generic: fix include guard name Kai Vehmanen
2019-09-10 18:29 ` [alsa-devel] [PATCH v3 07/10] ASoC: Intel: bxt-da7219-max98357a: common hdmi codec support Kai Vehmanen
2019-09-10 18:29 ` [alsa-devel] [PATCH v3 08/10] ASoC: Intel: glk_rt5682_max98357a: " Kai Vehmanen
2019-09-10 18:29 ` [alsa-devel] [PATCH v3 09/10] ASoC: intel: sof_rt5682: " Kai Vehmanen
2019-09-10 18:29 ` [alsa-devel] [PATCH v3 10/10] ASoC: Intel: bxt_rt298: " Kai Vehmanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccc1a764-532d-e21f-dd79-022699076154@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=libin.yang@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).