alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mateusz Gorski <mateusz.gorski@linux.intel.com>,
	alsa-devel@alsa-project.org
Cc: cezary.rojewski@intel.com, broonie@kernel.org, tiwai@suse.com
Subject: Re: [PATCH v6 0/3] Add support for different DMIC configurations
Date: Mon, 27 Apr 2020 08:30:55 -0500	[thread overview]
Message-ID: <ccec5162-ae44-3a71-5118-2539ade442f4@linux.intel.com> (raw)
In-Reply-To: <20200427132727.24942-1-mateusz.gorski@linux.intel.com>



On 4/27/20 8:27 AM, Mateusz Gorski wrote:
> Set of patches to enable DMIC capture on different hardware
> configurations.
> Information about supported DMIC configuration is read from NHLT and
> correct pipeline configuration is selected automatically.
> Also, adding additional option for topology binary name which is
> based on used machine driver.
> 
> Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> 
> Mateusz Gorski (3):
>    ASoC: Intel: Skylake: Add alternative topology binary name
>    ASoC: Intel: Multiple I/O PCM format support for pipe
>    ASoC: Intel: Skylake: Automatic DMIC format configuration according to
>      information from NHLT
> 
> Changes in v2:
> - removed patch 1/4 swapping machine device and platform device
>    registration order
> - alt_tplg_name creation now uses different field to read machine driver
>    name
> - including of <sound/soc-acpi.h> moved to different patch
> 
> Changes in v3:
> - cosmetic changes in skl-topology.c file
> 
> Changes in v4:
> - refactored patch 2/3 to use one common helper function to deal with both
>    set and get pipe configuration operations, as suggested by Pierre
> - adjusted patch 3/3 to also use this helper function for DMIC pipes
> - added comment in patch 3/3 explaining the change of access rights for
>    DMIC enums
> 
> Changes in v5:
> - fixed alignment issue in patch 2/3
> - addressed "checkpatch.pl --strict" warnings in patches
> 
> Changes in v6:
> - fixed commit message in patch 2/3
> 
>   include/uapi/sound/skl-tplg-interface.h |   2 +
>   sound/soc/intel/skylake/skl-topology.c  | 178 +++++++++++++++++++++++-
>   sound/soc/intel/skylake/skl-topology.h  |   1 +
>   3 files changed, 176 insertions(+), 5 deletions(-)
> 

  parent reply	other threads:[~2020-04-27 14:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 13:27 Mateusz Gorski
2020-04-27 13:27 ` [PATCH v6 1/3] ASoC: Intel: Skylake: Add alternative topology binary name Mateusz Gorski
2020-04-27 13:27 ` [PATCH v6 2/3] ASoC: Intel: Multiple I/O PCM format support for pipe Mateusz Gorski
2020-04-27 13:27 ` [PATCH v6 3/3] ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT Mateusz Gorski
2020-04-27 13:30 ` Pierre-Louis Bossart [this message]
2020-04-27 15:02 ` [PATCH v6 0/3] Add support for different DMIC configurations Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccec5162-ae44-3a71-5118-2539ade442f4@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=mateusz.gorski@linux.intel.com \
    --cc=tiwai@suse.com \
    --subject='Re: [PATCH v6 0/3] Add support for different DMIC configurations' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).