From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B1E3C352BE for ; Sat, 18 Apr 2020 18:58:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8665421D93 for ; Sat, 18 Apr 2020 18:58:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="EwhaUIub" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8665421D93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EDC14168C; Sat, 18 Apr 2020 20:57:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EDC14168C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587236307; bh=TfEofqp49HbWLNS/YzvAqA8UZmp6mII+JcBIQtSapHo=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EwhaUIubJUxdBF4ylSuhrHOosHjXo/w7vc1QNMKhiTnOw6fWE0kBt7Kmx4fmAjvAh 69YekFEC2k17ejDhHoc9Kiu9ah8IRtoO6WxI1TZ0AdgeRV3P+T9XQDnw+eUmsNkGKb Ia7hn8k1f7KBj/dFvfJ7zTf8dZLaInOMI7ANbKTE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 24114F8013D; Sat, 18 Apr 2020 20:57:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D2B93F80290; Sat, 18 Apr 2020 20:57:28 +0200 (CEST) Received: from smtprelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6A577F8013D for ; Sat, 18 Apr 2020 20:57:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6A577F8013D Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id AB7DD1801C62B; Sat, 18 Apr 2020 18:57:23 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: oven32_22ec242d00d03 X-Filterd-Recvd-Size: 2832 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Sat, 18 Apr 2020 18:57:19 +0000 (UTC) Message-ID: Subject: Re: [PATCH 7/9] drivers/base: fix empty-body warnings in devcoredump.c From: Joe Perches To: Randy Dunlap , Matthew Wilcox Date: Sat, 18 Apr 2020 11:55:05 -0700 In-Reply-To: References: <20200418184111.13401-1-rdunlap@infradead.org> <20200418184111.13401-8-rdunlap@infradead.org> <20200418185033.GQ5820@bombadil.infradead.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Dmitry Torokhov , Zzy Wysm , linux-kernel@vger.kernel.org, "J. Bruce Fields" , target-devel@vger.kernel.org, Dave Jiang , linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org, Vishal Verma , linux-input@vger.kernel.org, Alexander Viro , Dan Williams , Andrew Morton , linux-nfs@vger.kernel.org, "Martin K. Petersen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Takashi Iwai , Chuck Lever , linux-fsdevel@vger.kernel.org, Johannes Berg , Linus Torvalds X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 2020-04-18 at 11:53 -0700, Randy Dunlap wrote: > On 4/18/20 11:50 AM, Matthew Wilcox wrote: > > On Sat, Apr 18, 2020 at 11:41:09AM -0700, Randy Dunlap wrote: > > > @@ -294,11 +295,11 @@ void dev_coredumpm(struct device *dev, s > > > > > > if (sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj, > > > "failing_device")) > > > - /* nothing - symlink will be missing */; > > > + do_empty(); /* nothing - symlink will be missing */ > > > > > > if (sysfs_create_link(&dev->kobj, &devcd->devcd_dev.kobj, > > > "devcoredump")) > > > - /* nothing - symlink will be missing */; > > > + do_empty(); /* nothing - symlink will be missing */ > > > > > > INIT_DELAYED_WORK(&devcd->del_wk, devcd_del); > > > schedule_delayed_work(&devcd->del_wk, DEVCD_TIMEOUT); > > > > Could just remove the 'if's? > > > > + sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj, > > + "failing_device"); > > > > OK. sysfs_create_link is __must_check